Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-duplicate historic vs fetch/process fxns #74

Open
3 tasks
lindsayplatt opened this issue Sep 26, 2022 · 0 comments
Open
3 tasks

De-duplicate historic vs fetch/process fxns #74

lindsayplatt opened this issue Sep 26, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@lindsayplatt
Copy link
Contributor

I built this pipeline so that the historic download component is completely separate. During that development, I decided to duplicate fxns but name them with _historic so that I wouldn't have to worry about tiny changes in the fetch/process components causing a rebuild of the historic data.

As Cee points out here, that was not the best idea because it sets us up for potential future issues with changing one but forgetting to change the other. I should go through and de-duplicate those shared functions to clean this workflow up.

Here's my plan for tackling:

  • Make a list/table of the duplicate fxns
  • Create a shared fxn file
  • Rebuild both historic and the current dates with the new shared fxns
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant