Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix brittle merging of secchi data from multiple files #193

Open
2 tasks
jordansread opened this issue Dec 15, 2020 · 0 comments
Open
2 tasks

Fix brittle merging of secchi data from multiple files #193

jordansread opened this issue Dec 15, 2020 · 0 comments

Comments

@jordansread
Copy link

This came up during work done in #191

Prior to that PR, WQP was the only source of secchi data. I linked LAGOS secchi and modified the munge_Kw() function to accept any number of secchi files. But to do that, we need to be able to expect that they have the same file format and column headers. Neither of these conditions were met by the two initial files: WQP is a feather with id instead of site_id, and lagos is an rds with site_id. I coded a temporary workaround because I wasn't sure what the downstream implications of changing the WQP file would be.

brittle code is here

  • just like munge_H_A() we want order to matter in the file inputs
  • need to lock in an expected file format and fail nicely (with a message making it clear why this failed) if the conditions are not met
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant