Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gripe more then issue: Topology specification #350

Open
mikejohnson51 opened this issue Aug 16, 2023 · 2 comments
Open

Gripe more then issue: Topology specification #350

mikejohnson51 opened this issue Aug 16, 2023 · 2 comments

Comments

@mikejohnson51
Copy link
Contributor

It is difficult to build a smooth workflow when both calculate_arbolate_sum and add_plus_network_attributes are needed because the former requires a ID/toID topology and the latter a comid/tocomid topology.

Would you be interested in changing add_plus_network_attributes to need the more general ID/toID set?
@dblodgett-usgs
Copy link
Collaborator

Yeah... there's still some messiness to all the attribute handling. That would be possible in hydroloom -- but I haven't packaged it up that way.

Once the hydroloom branch is out, a lot more will be possible.

@dblodgett-usgs
Copy link
Collaborator

@mikejohnson51 -- are you still using the functions from nhdplusTools for these? Think it's worth the time to clean up here or should we maybe just deprecate the functions in nhdplusTools?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dblodgett-usgs @mikejohnson51