Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility of removing/adding new file to executable #1526

Closed
baziorek opened this issue Apr 12, 2022 · 7 comments · Fixed by #2151
Closed

Possibility of removing/adding new file to executable #1526

baziorek opened this issue Apr 12, 2022 · 7 comments · Fixed by #2151

Comments

@baziorek
Copy link

baziorek commented Apr 12, 2022

I'm using DOMjudge for academic teaching. I'm creating new executable for each problem, because I'm checking submissions with Unit Tests in C++.
Unfortunately it is really hard to make its many times, because:

  1. sometimes I add file by accident - the only way to remove the file is to attach entire executable again, then correct language to use the new script
  2. sometimes I forgot to add some file - the only way as above
  3. sometimes in files are national characters e.g. "ąśćżźć" and the text file is detected as binary and I can't edit

Possibility of adding/removing file would solve all the problems above.

I'm using DOMjudge: 7.3.4

meisterT added a commit to meisterT/domjudge that referenced this issue Apr 17, 2022
This now allows to have non-ASCII characters as `ąśćżźć` to not trigger
false positives.

Also show a nicer alert message while we are changing this code.

Part of DOMjudge#1526.
meisterT added a commit that referenced this issue Apr 17, 2022
…1535)

This now allows to have non-ASCII characters as `ąśćżźć` to not trigger
false positives.

Also show a nicer alert message while we are changing this code.

Part of #1526.
meisterT added a commit to meisterT/domjudge that referenced this issue Apr 17, 2022
This is one more step in simplifying working with executables and part
of DOMjudge#1526.
meisterT added a commit that referenced this issue Apr 17, 2022
This is one more step in simplifying working with executables and part
of #1526.
meisterT added a commit to meisterT/domjudge that referenced this issue Apr 18, 2022
meisterT added a commit to meisterT/domjudge that referenced this issue Apr 19, 2022
meisterT added a commit that referenced this issue Apr 19, 2022
* Allow deletion of individual files in executable.

Part of #1526.
@baziorek
Copy link
Author

Hi,
I see that it was done in commits:

  1. Allow deletion of individual files in executable. #1539
  2. Improve detection of binary file encoding when editing executables. #1535
  3. Merge view and edit of executable content onto one page. #1536

Thanks really much for making easier to edit executables!

What should I do now - it looks that the issue is implemented, so should I close its?

@meisterT
Copy link
Member

I'm not fully done yet improving and simplifying the interface

@meisterT
Copy link
Member

meisterT commented Dec 4, 2022

Also what I just noticed when running another contest: we drop binary files (such as executables) when editing.

@eldering
Copy link
Member

eldering commented May 8, 2023

See also #1841

@meisterT
Copy link
Member

This is how the executables overview looks like now:
image

Possible improvements:

  • put the id in code tags
  • separate out used from unused executables
  • either use some fontawesome icon or similar to visually distinguish the executable type
  • perhaps up for debate: for the currently selected contest, add problem badges where appropriate

@nickygerritsen
Copy link
Member

I like all these. Maybe even a table per type?

@vmcj
Copy link
Member

vmcj commented Sep 17, 2023

I like all these. Maybe even a table per type?

If we do the table, would we still want the icon?

@vmcj vmcj linked a pull request Oct 5, 2023 that will close this issue
@vmcj vmcj closed this as completed in #2151 Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants