Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logger warnlevel when normalizing request time #269

Closed
martinalig opened this issue Oct 30, 2020 · 3 comments
Closed

Fix logger warnlevel when normalizing request time #269

martinalig opened this issue Oct 30, 2020 · 3 comments

Comments

@martinalig
Copy link
Contributor

Currently, there is an ERROR logged when the request time exceeds the configured normalized request time in the GaenController exposed and exposedNextDay requests.

This is clearly not an error, so the level should be adjustet to WARN. Also some more information could be printet out, how much too long the request ist actually going.

@ineiti
Copy link
Collaborator

ineiti commented Oct 30, 2020

This is an error, and is there explicitly to be an error! If the request exceeds the normalized request time, then the normalized request time needs to be increased, else an attacker could learn something about the state of the database.

So the correct solution for this error is to increase the normalized request time.

@ineiti
Copy link
Collaborator

ineiti commented Oct 30, 2020

See #270

@martinalig
Copy link
Contributor Author

Closed, as already explained by @ineiti
This is an error as this actually breaks the system from a privacy perspective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants