Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binding for React Native #29

Open
jdesboeufs opened this issue Apr 22, 2020 · 7 comments
Open

Binding for React Native #29

jdesboeufs opened this issue Apr 22, 2020 · 7 comments
Labels
stale Issue is awaiting input from creator for prolonged time period

Comments

@jdesboeufs
Copy link

Hello,

Thank you for your amazing work on this SDK! 🙏
I'm working on a non-profit and open source initiative to provide an alternative contact tracing application for France, based on DP-3T.
We would like to adapt your demo app, but we don't have iOS/Android developers available at the moment. But we have React ones (I am), so we are looking for a React native binding.

Do you have plan for that?
I found this: https://github.com/wix-incubator/react-native-dp3t
But it is not very active.

It is probably not a DP-3T core team priority, but if there are other people asking the same question, maybe we could work together :)

@stephane-klein
Copy link

Original Tweet about that https://twitter.com/jdesboeufs/status/1252876654189309952

@fmauquie
Copy link
Contributor

fmauquie commented Apr 24, 2020

Hi,

I am giving it a shot here: https://github.com/fmauquie/react-native-dp3t-sdk

It is not ready at all (and not published on NPM), but the example app compiles and starts.

I intend to implement basic functionality in the example app to give an example and test the bindings.

@jdesboeufs
Copy link
Author

@fmauquie It's great!
Tell us if you need help!

@ButtersHub
Copy link

ButtersHub commented Apr 29, 2020

@jdesboeufs actually we started wrapping this lib for RN as well, you can find it here, but we found that the business-logic & encryption are very coupled with the library, and we would like to adjust them for our need, so it will be difficult to work with this SDK, I wrote about this in this issue

We decided to build our own RN library, which will be a bit more modular, you can find it here, feel free to contact me if you need help.

@jdesboeufs
Copy link
Author

Thank you @ButtersHub,

But it's very important for us to rely on the DP-3T SDK.
@fmauquie Have you noticed the issue reported by @ButtersHub ?

@fmauquie
Copy link
Contributor

I like the "turnkey" approach of this repo, it allows app writers to "just plug the lib and go". APIs from both platforms are also relatively in sync and easy to grasp. There are multiple aspects to DP3T that I really don't want to be tackling (data security, crypto, sync, risk scoring, auth…) so having an integrated solution is great.

I also understand the concerns raised by @ButtersHub : even as I implement the bindings, some design decisions in the SDK make it difficult when working with RN because of different behaviors between RN and other native apps (this is less of a problem with the Android SDK because Android is kind of lax with regard to object privacy). However the team is responsive in the PRs, so the SDK can adapt.

I also think that having another implementation is always good. I have embedded a link in my readme pointing to Wix's implementation. I haven't looked into it in detail, but I certainly will.

@UBaggeler
Copy link
Contributor

We currently do not provide any bindings for RN. Feel free to send a pull-request.

@UBaggeler UBaggeler added the stale Issue is awaiting input from creator for prolonged time period label Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issue is awaiting input from creator for prolonged time period
Projects
None yet
Development

No branches or pull requests

5 participants