From 1c4b5579b89ead46317e11469b4aeeb1fd63cf80 Mon Sep 17 00:00:00 2001
From: Michael Rittmeister <michael@rittmeister.in>
Date: Fri, 22 Sep 2023 12:16:47 +0200
Subject: [PATCH] Improve in app update - Add translations - Handle status
 PENDING, CANCELLED and FAILED

---
 .../src/main/java/UpdateAwareAppScope.kt      | 34 +++++++++----------
 .../src/main/res/values-de-rDE/strings.xml    |  4 +++
 app/android/src/main/res/values/strings.xml   |  4 +++
 3 files changed, 24 insertions(+), 18 deletions(-)

diff --git a/app/android/src/main/java/UpdateAwareAppScope.kt b/app/android/src/main/java/UpdateAwareAppScope.kt
index 25118a5..53d5b24 100644
--- a/app/android/src/main/java/UpdateAwareAppScope.kt
+++ b/app/android/src/main/java/UpdateAwareAppScope.kt
@@ -3,12 +3,7 @@ package dev.schlaubi.tonbrett.app.android
 import android.app.Activity
 import android.util.Log
 import androidx.compose.foundation.background
-import androidx.compose.foundation.layout.Arrangement
-import androidx.compose.foundation.layout.Box
-import androidx.compose.foundation.layout.Column
-import androidx.compose.foundation.layout.Row
-import androidx.compose.foundation.layout.fillMaxSize
-import androidx.compose.foundation.layout.padding
+import androidx.compose.foundation.layout.*
 import androidx.compose.foundation.shape.RoundedCornerShape
 import androidx.compose.material.icons.Icons
 import androidx.compose.material.icons.filled.OpenInNew
@@ -16,17 +11,11 @@ import androidx.compose.material3.Button
 import androidx.compose.material3.Icon
 import androidx.compose.material3.MaterialTheme
 import androidx.compose.material3.Text
-import androidx.compose.runtime.Composable
-import androidx.compose.runtime.LaunchedEffect
-import androidx.compose.runtime.SideEffect
-import androidx.compose.runtime.getValue
-import androidx.compose.runtime.mutableStateOf
-import androidx.compose.runtime.remember
-import androidx.compose.runtime.rememberCoroutineScope
-import androidx.compose.runtime.setValue
+import androidx.compose.runtime.*
 import androidx.compose.ui.Alignment
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.platform.LocalContext
+import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.unit.dp
 import androidx.compose.ui.zIndex
 import com.google.android.play.core.appupdate.AppUpdateInfo
@@ -37,6 +26,7 @@ import com.google.android.play.core.install.model.AppUpdateType
 import com.google.android.play.core.install.model.InstallStatus
 import kotlinx.coroutines.launch
 import kotlinx.coroutines.tasks.await
+import java.text.NumberFormat
 
 @Composable
 fun UpdateAwareAppScope(activity: Activity, content: @Composable () -> Unit) {
@@ -50,6 +40,7 @@ fun UpdateAwareAppScope(activity: Activity, content: @Composable () -> Unit) {
     val progressListener = remember {
         InstallStateUpdatedListener {
             when (it.installStatus()) {
+                InstallStatus.PENDING -> progress = -100.0
                 InstallStatus.DOWNLOADING -> {
                     progress =
                         it.bytesDownloaded().toDouble() / it.totalBytesToDownload().toDouble()
@@ -59,6 +50,11 @@ fun UpdateAwareAppScope(activity: Activity, content: @Composable () -> Unit) {
                     progress = 2.0
                 }
 
+                InstallStatus.FAILED, InstallStatus.CANCELED -> {
+                    progress = null
+                    updateInfo = null
+                }
+
                 else -> {}
             }
         }
@@ -107,7 +103,9 @@ fun UpdateAwareAppScope(activity: Activity, content: @Composable () -> Unit) {
 
                     }
 
-                    if (currentProgress < 0) {
+                    if (currentProgress == -100.0) {
+                      Info(stringResource(R.string.update_pending))
+                    } else if (currentProgress < 0) {
                         Button(onClick = { scope.launch {
                             appUpdateManager.startUpdateFlow(
                                 currentUpdateInfo,
@@ -115,10 +113,10 @@ fun UpdateAwareAppScope(activity: Activity, content: @Composable () -> Unit) {
                                 AppUpdateOptions.defaultOptions(AppUpdateType.FLEXIBLE)
                             )
                         } }) {
-                            Info("Update Available")
+                            Info(stringResource(R.string.update_available))
                         }
                     } else if (currentProgress in 0.0..1.0) {
-                        Info("Updating")
+                        Info(stringResource(R.string.update_downloading, NumberFormat.getPercentInstance().format(currentProgress)))
                     } else {
                         Button(onClick = {
                             scope.launch {
@@ -126,7 +124,7 @@ fun UpdateAwareAppScope(activity: Activity, content: @Composable () -> Unit) {
                             }
                         }) {
                             Icon(Icons.Default.OpenInNew, null)
-                            Info("Update Available")
+                            Info(stringResource(R.string.update_download_done))
                         }
                     }
                 }
diff --git a/app/android/src/main/res/values-de-rDE/strings.xml b/app/android/src/main/res/values-de-rDE/strings.xml
index 5293ffc..d5dc2e9 100644
--- a/app/android/src/main/res/values-de-rDE/strings.xml
+++ b/app/android/src/main/res/values-de-rDE/strings.xml
@@ -1,4 +1,8 @@
 <?xml version="1.0" encoding="utf-8"?>
 <resources>
     <string name="retry">Erneut versuchen</string>
+    <string name="update_available">Update verfügbar</string>
+    <string name="update_pending">Update begonnen</string>
+    <string name="update_downloading">Update wird hertuntergeladen: %s</string>
+    <string name="update_download_done">Update Installieren</string>
 </resources>
\ No newline at end of file
diff --git a/app/android/src/main/res/values/strings.xml b/app/android/src/main/res/values/strings.xml
index 20043fc..2c9bbfe 100644
--- a/app/android/src/main/res/values/strings.xml
+++ b/app/android/src/main/res/values/strings.xml
@@ -1,3 +1,7 @@
 <resources>
     <string name="retry">Retry</string>
+    <string name="update_available">Update available</string>
+    <string name="update_pending">Update queued</string>
+    <string name="update_downloading">Downloading: %s</string>
+    <string name="update_download_done">Install Update</string>
 </resources>
\ No newline at end of file