-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Submission: 2: Heart Disease Prediction #2
Comments
Data analysis review checklistReviewer: Shravan37Conflict of interest
Code of Conduct
General checks
Documentation
Code quality
Reproducibility
Analysis report
Estimated hours spent reviewing: 60 minutesReview Comments:Please provide more detailed feedback here on what was done particularly well, and what could be improved. It is especially important to elaborate on items that you were not able to check off in the list above.
AttributionThis was derived from the JOSE review checklist and the ROpenSci review checklist. |
Data analysis review checklistReviewer: <GITHUB_USERNAME>Conflict of interest
Code of Conduct
General checks
Documentation
Code quality
Reproducibility
Analysis report
Estimated hours spent reviewing: 60 minutesReview Comments:Please provide more detailed feedback here on what was done particularly well, and what could be improved. It is especially important to elaborate on items that you were not able to check off in the list above. 1First of all, I think you missed the attribe_box_plots.r file under "/opt/notebooks/R" and the processed-cleveland.csv file under "/opt/notebooks/data/processed-cleveland.csv", this causes some errors when I run the notebook file on the docker container. I think it's mainly because when you focus on milestone 3 and made a lot of changes on the file names, but forget to update it on the predicting_heart_disease.ipynb file. This makes the .ipynb file difficult to run interactively. 2"In this project, we used 13 attributes to predict whether a person has heart disease or not." 3I fail to render the "doc/heart_disease.html doc/heart_disease.pdf" file. So I try to knit the heart_disease.rmd file locally, but still get some errors, like missing ":" after "github_document". So, The readme could have done a better job of describing everything, and getting rid of some typos. AttributionThis was derived from the JOSE review checklist and the ROpenSci review checklist. |
Data analysis review checklistReviewer: <GITHUB_USERNAME>Conflict of interest
Code of Conduct
General checks
Documentation
Code quality
Reproducibility
Analysis report
Estimated hours spent reviewing:1 hour Review Comments:Please provide more detailed feedback here on what was done particularly well, and what could be improved. It is especially important to elaborate on items that you were not able to check off in the list above.
This may be a small thing, but from my understanding, the hyperparameter you are tuning is not the number of classifiers. I believe that you are tuning the k-value, which determines how many neighbours are being used given an unspecified center.
AttributionThis was derived from the JOSE review checklist and the ROpenSci review checklist. |
Data analysis review checklistReviewer: samzzzzzhConflict of interest
Code of Conduct
General checks
Documentation
Code quality
Reproducibility
Analysis report
Estimated hours spent reviewing: one hour and halfReview Comments:Please provide more detailed feedback here on what was done particularly well, and what could be improved. It is especially important to elaborate on items that you were not able to check off in the list above. Before getting into the feedbacks I want to say good job to all of you since the project looks really solid and I really like the research question! Being able to predict risk of heart disease is pretty cool and could potentially save tons of lives. However there are couple small flaws and I noted them below. Hopefully this can help you folks in the final project!
"Quitting from lines 18-31 (heart_disease.rmd) Execution halted I tried to knit the .rmd file locally but errors are still occurring. I think there may be some typos in the code that needs to be sorted out. One way to solve this problem is to be more concrete in the instructions of how to run the analysis. I would assume whoever is reading my file knows nothing about any of the software and take them step by step. Maybe this will help with the issue of reproducibility or at least make the process easier for other users.
"Error in library(DSCI - 310 - Group - 2) : 'package' must be of length 1 I suspect that there may be issues with the name. The spacing in between the names seems odd and I could not get the test suite running. Try search up "package must be length 1" and I am sure the solution is somewhere on the internet.
AttributionThis was derived from the JOSE review checklist and the ROpenSci review checklist. |
Submitting authors: @eahn01 @dliviya @rpeng35 @nikizamani
Repository: https://github.com/DSCI-310/DSCI-310-Group-2
Abstract/executive summary:
Common heart diseases include disease of the blood vessel, arrhythmia (irregular beating of the heart), disease of the heart valve and muscle, infection of the heart, and heart defects from birth. The symptoms of heart diseases are often times unnoticeable and most are only diagnosed after a heart attack,heart failure, or stroke. In this project, we want to be able to predict if someone is at risk of a heart disease based on the variables given in the dataset.
Editor: @ttimbers
Reviewer: @Shravan37 @AaronMKk @ChoAllan @samzzzzzh
The text was updated successfully, but these errors were encountered: