Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deque Analysis] ARIA / Label Issues in Submission form (Critical) #1272

Open
tdonohue opened this issue Jul 12, 2021 · 2 comments
Open

[Deque Analysis] ARIA / Label Issues in Submission form (Critical) #1272

tdonohue opened this issue Jul 12, 2021 · 2 comments
Labels
accessibility bug component: submission Difficulty: High Estimated at more than 16 hours help wanted Needs a volunteer to claim to move forward high priority

Comments

@tdonohue
Copy link
Member

tdonohue commented Jul 12, 2021

Critical: This issue results in blocked content for people with disabilities, and will definitely prevent them from accessing fundamental features or content. This type of issue puts your organization at risk. Prioritize fixing as soon as possible, within the week if possible. Remediation should be a top priority.

Deque Analysis Summary

Two remaining Submission form critical issues exist after #1252. Both of these seem to be caused by external libraries.

  1. (Issue ID: 469503) The aria-multiline attribute is invalid on combobox role (it currently appears for dc.subject field). See https://www.w3.org/TR/wai-aria-1.1/#aria-multiline It should be removed.
  2. (Issue ID: 469538) The <select> for the dc.identifier field doesn't have a <label> or an aria-label attribute.
    • That element is added by the form library

The full list of these issues (which includes links for more info) can be found at this link (requires login): https://axeauditor.dequecloud.com/test-run/0856438a-a19a-11eb-bc31-b7d5be387c86/issues?activeTab=dt-issue&page=0&pageSize=100&sortField=ordinal&sortDir=asc&row=9&filter%5Bseverity%5D=4&filter%5Bpage_number%5D=10&filter%5Bpage_number%5D=11

More Information / Tools

@tdonohue tdonohue added this to the 7.1 milestone Jul 12, 2021
@tdonohue tdonohue changed the title [Deque Analysis] ARIA / Label Issues in Submission form [Deque Analysis] ARIA / Label Issues in Submission form (Critical) Jul 12, 2021
@tdonohue tdonohue removed this from the 7.1 milestone Oct 6, 2021
@atarix83
Copy link
Contributor

atarix83 commented Nov 10, 2021

@tdonohue

(Issue ID: 469503) The aria-multiline attribute is invalid on combobox role (it currently appears for dc.subject field). See https://www.w3.org/TR/wai-aria-1.1/#aria-multiline It should be removed.
the aria is added by the ngbTypeahead component,

I've opened an issue to ng-bootstrap, since I don't see other ways to fix this issue

ng-bootstrap/ng-bootstrap#4181

@atarix83 atarix83 self-assigned this Nov 10, 2021
@tdonohue
Copy link
Member Author

@atarix83 : Thanks for letting me know. In that case, we'll wait to see if there's response from ng-bootstrap on how to fix that first issue. If we need to, we can separate that out into a different ticket & make it a lower priority, since it's not something we can take action on.

In that case, I'd just recommend seeing if we can solve
(Issue ID: 469538) The <select> for the dc.identifier field doesn't have a <label> or an aria-label attribute.

@tdonohue tdonohue added Difficulty: High Estimated at more than 16 hours help wanted Needs a volunteer to claim to move forward and removed Estimate TBD labels Dec 6, 2023
4science-it pushed a commit to 4Science/dspace-angular that referenced this issue Jan 26, 2024
…ternal-links (pull request DSpace#1272)

DSC-1484 create utility functions to handle internal and external links

Approved-by: Davide Negretti
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility bug component: submission Difficulty: High Estimated at more than 16 hours help wanted Needs a volunteer to claim to move forward high priority
Projects
Development

No branches or pull requests

2 participants