-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Deque Analysis] ARIA / Label Issues in Submission form (Critical) #1272
Comments
I've opened an issue to ng-bootstrap, since I don't see other ways to fix this issue |
@atarix83 : Thanks for letting me know. In that case, we'll wait to see if there's response from ng-bootstrap on how to fix that first issue. If we need to, we can separate that out into a different ticket & make it a lower priority, since it's not something we can take action on. In that case, I'd just recommend seeing if we can solve |
…ternal-links (pull request DSpace#1272) DSC-1484 create utility functions to handle internal and external links Approved-by: Davide Negretti
Deque Analysis Summary
Two remaining Submission form critical issues exist after #1252. Both of these seem to be caused by external libraries.
aria-multiline
attribute is invalid oncombobox
role (it currently appears fordc.subject
field). See https://www.w3.org/TR/wai-aria-1.1/#aria-multiline It should be removed.@ng-dynamic-forms
#2216 because the@ng-dynamic-forms
library is blocking us from upgrading to the latest version ofng-bootstrap
(and Bootstrap 5) where this bug is fixed.<select>
for thedc.identifier
field doesn't have a<label>
or anaria-label
attribute.The full list of these issues (which includes links for more info) can be found at this link (requires login): https://axeauditor.dequecloud.com/test-run/0856438a-a19a-11eb-bc31-b7d5be387c86/issues?activeTab=dt-issue&page=0&pageSize=100&sortField=ordinal&sortDir=asc&row=9&filter%5Bseverity%5D=4&filter%5Bpage_number%5D=10&filter%5Bpage_number%5D=11
More Information / Tools
The text was updated successfully, but these errors were encountered: