Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page size change and sorting doesn't work on some pages #2996

Closed
Leano1998 opened this issue May 2, 2024 · 5 comments · Fixed by #3080
Closed

Page size change and sorting doesn't work on some pages #2996

Leano1998 opened this issue May 2, 2024 · 5 comments · Fixed by #3080
Assignees
Labels
bug claimed: Atmire Atmire team is working on this issue & will contribute back component: Collection Collection display or editing component: Community Community display or editing component: configurable entities related to configurable entities high priority testathon Reported by a tester during Community Testathon
Milestone

Comments

@Leano1998
Copy link
Contributor

Describe the bug
If you want to change the number of items on the edit-relations-lookup (edit-items -> relationships -> +Add) or change the sort settings it doesn't work. The same happens, if you try to do the same thing on a community-page in the search section.

To Reproduce

  1. Edit an entity-item
  2. Navigate to the relationship-tab and click Add + to add a new relationship.
  3. Try to change the sort order or the number of items per page

The list of found items doesn't change. (If you click Select page the page will be selected and afterwards the sorting-changes/number-of-items are applied.)

Expected behavior
The settings should be applied.

@Leano1998 Leano1998 added bug needs triage New issue needs triage and/or scheduling labels May 2, 2024
@github-project-automation github-project-automation bot moved this to 🆕 Triage in DSpace Backlog May 2, 2024
@tdonohue
Copy link
Member

tdonohue commented May 2, 2024

I can reproduce this on the Sandbox (https://sandbox.dspace.org). It's also very easy to reproduce as follows:

  1. Browse to any Community/Collection page
  2. On the "Search" tab (default tab), in the sidebar change the "Results per page" from 10 to 20.
  3. The entire page hangs. It become unresponsive. It doesn't appear to send a request to the REST API, but the page just shows the "loading" dots and never returns.

Flagging as high priority because it's very easy to end up with an unresponsive site.

@tdonohue tdonohue added component: configurable entities related to configurable entities component: Community Community display or editing component: Collection Collection display or editing testathon Reported by a tester during Community Testathon and removed needs triage New issue needs triage and/or scheduling labels May 2, 2024
@tdonohue tdonohue removed this from DSpace Backlog May 2, 2024
@github-project-automation github-project-automation bot moved this to 📋 To Do in DSpace 8.0 Release May 2, 2024
@tdonohue
Copy link
Member

tdonohue commented May 2, 2024

Pinging @artlowel and @alexandrevryghem in case this is of interest. It sounds related to #2732 (from @alexandrevryghem ) and also possibly related to #2978 (which @artlowel has claimed). It might be the same issue on both pages, or slightly different (not sure).

If you are interested, let me know or claim it for yourself.

@alexandrevryghem alexandrevryghem self-assigned this May 3, 2024
@alexandrevryghem alexandrevryghem added the claimed: Atmire Atmire team is working on this issue & will contribute back label May 3, 2024
@tdonohue
Copy link
Member

@alexandrevryghem : Are you still working on this one? Ideally, this would be nice to fix prior to 8.0 since it's currently possible to cause the search page to "hang indefinitely" as described here: #2996 (comment)

@alexandrevryghem
Copy link
Member

@tdonohue: Yes I'll try to look into it tomorrow/next week

@tdonohue
Copy link
Member

@alexandrevryghem : Just a reminder this might be good to fix in time for 8.0, if possible to do so.

@tdonohue tdonohue moved this from 📋 To Do to 🏗 In Progress in DSpace 8.0 Release May 24, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in DSpace 8.0 Release May 29, 2024
@tdonohue tdonohue added this to the 8.0 milestone May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug claimed: Atmire Atmire team is working on this issue & will contribute back component: Collection Collection display or editing component: Community Community display or editing component: configurable entities related to configurable entities high priority testathon Reported by a tester during Community Testathon
Projects
No open projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants