Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite load times on "My DSpace" #3697

Open
pnbecker opened this issue Nov 29, 2024 · 3 comments
Open

Infinite load times on "My DSpace" #3697

pnbecker opened this issue Nov 29, 2024 · 3 comments
Labels
bug error handling How errors are handled from REST API help wanted Needs a volunteer to claim to move forward high priority performance / caching Related to performance, caching or embedded objects

Comments

@pnbecker
Copy link
Member

Describe the bug

We get user reports of infinite load times on "my DSpace". From what we hear this happens more likely if you finished one or multiple submissions without reloading the page in between. I tried to reproduce this on demo.dspace.org. So far I was able to reproduce it once when playing around with the workflow task filters. Unfortunately I have no clear path to reproduce it.

If you read this issue, did you run into the same problem? Can you describe what you did before? Are you a developer and did spot some code in my dspace that you thing might be the cause of this?

This is related to #3677

@pnbecker pnbecker added bug needs triage New issue needs triage and/or scheduling labels Nov 29, 2024
@github-project-automation github-project-automation bot moved this to 🆕 Triage in DSpace Backlog Nov 29, 2024
@pnbecker pnbecker added performance / caching Related to performance, caching or embedded objects error handling How errors are handled from REST API labels Nov 29, 2024
@tdonohue tdonohue added help wanted Needs a volunteer to claim to move forward high priority and removed needs triage New issue needs triage and/or scheduling labels Dec 2, 2024
@kshepherd
Copy link
Member

kshepherd commented Dec 2, 2024

one question i have while digging around code that parses submission objects/data from the my dspace page -- what is the purpose of these deepClone calls in submission-response-parsing-service.ts?

  parse(request: RestRequest, data: RawRestResponse): ParsedResponse {
    this.dsoParser.parse(deepClone(request), deepClone(data));
    if (isNotEmpty(data.payload)
      && isNotEmpty(data.payload._links)
      && this.isSuccessStatus(data.statusCode)) {
      const dataDefinition = this.processResponse<SubmissionObject | ConfigObject>(data.payload, request);
      return new ParsedResponse(data.statusCode, undefined, { dataDefinition });
    } else if (isEmpty(data.payload) && this.isSuccessStatus(data.statusCode)) {
      return new ParsedResponse(data.statusCode);
    } else {
      throw new Error('Unexpected response from server');
    }
  }

@kanasznagyzoltan
Copy link

I have a similar problem in DSpace 8.0, if i have created a new submission, right after the new submission if a click on Editing the new item i immediately getting an infinite load error.

dspace_crash_after_editing_a_new_submission_1
dspace_crash_after_editing_a_new_submission_2
dspace_crash_after_editing_a_new_submission_3
dspace_crash_after_editing_a_new_submission_4

Could the related PR (#3677) also solve my issue? (That PR has 1 approval and 1 pending reviewer maybe it is close to happiness :))

Thank you for the info!

@alexandrevryghem
Copy link
Member

@kanasznagyzoltan : Yes that bug should be resolved with #3677

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug error handling How errors are handled from REST API help wanted Needs a volunteer to claim to move forward high priority performance / caching Related to performance, caching or embedded objects
Projects
Status: 📋 To Do
Development

No branches or pull requests

5 participants