Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No platform specific code in abstract services main #3981

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

No platform specific code in abstract services main #3981

wants to merge 4 commits into from
+94 −37

Conversation

AAwouters
Copy link
Contributor

@AAwouters AAwouters commented Feb 13, 2025 •
edited
Loading

References

Description

Moves platform-specific imports out of the abstract Cookie- and AuthService and moves them to ServerCookie- and ServerAuthService.

Instructions for Reviewers

This PR does not directly produce an observable difference.
It does solve the problem mentioned in #3974.

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@AAwouters
125969: Move constructor to server-cookie.service
8b90d99 
This makes it possible to remove the REQUEST import from
cookie.service.ts which solves a typescript issue.
@AAwouters
125969: Get rid of REQUEST and RESPONSE imports in AuthService
f82426b
@AAwouters
125969: Fix auth service tests
961bb11
@AAwouters
Merge branch 'no-platform-specific-code-in-abstract-services-7.6' int…
3197ec9 
…o no-platform-specific-code-in-abstract-services-main

# Conflicts:
#	src/app/core/auth/auth.service.ts
#	src/app/core/auth/server-auth.service.ts
#	src/app/core/services/cookie.service.ts
#	src/app/core/services/server-cookie.service.ts
This was referenced Feb 13, 2025
Open
Open
@AAwouters AAwouters marked this pull request as ready for review March 7, 2025 09:07
@tdonohue tdonohue added bug high priority 1 APPROVAL pull request only requires a single approval to merge labels Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@AAwouters AAwouters

Labels
1 APPROVAL pull request only requires a single approval to merge bug high priority
Projects
DSpace 9.0 Release
Status: 🙋 Needs Reviewers Assigned
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Abstract services should not inject server/client-specific code
2 participants
@AAwouters @tdonohue