Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made AdminSearchPageComponent themeable #3065

Merged
merged 6 commits into from
Dec 10, 2024
Merged

Made AdminSearchPageComponent themeable #3065

merged 6 commits into from
Dec 10, 2024
+109 −11

Conversation

alexandrevryghem
Copy link
Member

@alexandrevryghem alexandrevryghem commented May 21, 2024 •
edited
Loading

References

Description

Made AdminSearchPageComponent and AdminWorkflowPageComponent themeable & fixed minor css issue where the navbar would overflow over the breadcrumbs in mobile mode

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@alexandrevryghem
115051: Created ThemedAdminSearchPageComponent
99384a7
@alexandrevryghem
Merge branch 'w2p-115051_themed-admin-search-page_contribute-7.4' int…
89e4d3b 
…o new-themed-components_contribute-main

# Conflicts:
#	src/app/admin/admin-routing.module.ts
#	src/app/admin/admin-search-page/admin-search.module.ts
#	src/themes/custom/lazy-theme.module.ts
@alexandrevryghem
Fixed navbar overflowing over breadcrumbs in mobile mode in custom theme
61e52cd
@tdonohue tdonohue added the 1 APPROVAL pull request only requires a single approval to merge label May 21, 2024
@alexandrevryghem
115051: Created ThemedAdminWorkflowPageComponent
970b19b
@alexandrevryghem
Merge remote-tracking branch 'w2p-115051_themed-admin-search-page_con…
25e2e29 
…tribute-7.4' into new-themed-components_contribute-main

# Conflicts:
#	src/app/admin/admin-routing.module.ts
#	src/app/admin/admin-workflow-page/admin-workflow.module.ts
#	src/themes/custom/lazy-theme.module.ts
@alexandrevryghem alexandrevryghem mentioned this pull request Jun 22, 2024
Closed
@alexandrevryghem alexandrevryghem added bug accessibility component: Discovery related to discovery search or browse system labels Jun 22, 2024
@tdonohue tdonohue self-requested a review August 8, 2024 14:52
nwoodward
nwoodward reviewed Dec 5, 2024
View reviewed changes
Copy link
Contributor

@nwoodward nwoodward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alexandrevryghem! I tested this and confirmed that I can add Admin Search and Workflow to a custom theme. And it fixes an obvious bug with the MetadataService. I just had one little change to update the function comment.

@alexandrevryghem
Fixed search facet deadlock
446280b 
Also fixed minor issue in MetadataService, but this doesn't cause any issues in the current code
@alexandrevryghem alexandrevryghem force-pushed the new-themed-components_contribute-main branch from 13e6bed to 446280b Compare December 5, 2024 20:37
nwoodward
nwoodward approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@nwoodward nwoodward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good!

@tdonohue tdonohue added port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release labels Dec 10, 2024
tdonohue
tdonohue approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @alexandrevryghem ! Verified that this also fixes the missing focus indicator accessibility bug. Code looks good. Because this includes an accessibility fix, I'm marking this to be ported to 8.x & 7.x. If the automated ports don't succeed, we'll want to minimally port the accessibility fix to those releases.

@tdonohue tdonohue added this to the 9.0 milestone Dec 10, 2024
@tdonohue tdonohue merged commit ac00f88 into DSpace:main Dec 10, 2024
13 checks passed
@dspace-bot
Copy link
Contributor

Backport failed for dspace-7_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-7_x
git worktree add -d .worktree/backport-3065-to-dspace-7_x origin/dspace-7_x
cd .worktree/backport-3065-to-dspace-7_x
git switch --create backport-3065-to-dspace-7_x
git cherry-pick -x 99384a70605b2eccaaae249103673c3735da8c85 61e52cd2abb8ec5dea4b17170e93fe190b086dc9 970b19bf0104a9f361717d148bfc66a60e70e239 446280b59a65c8c0ce24a796ffd14b5eef6eafd0

@dspace-bot
Copy link
Contributor

Backport failed for dspace-8_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-8_x
git worktree add -d .worktree/backport-3065-to-dspace-8_x origin/dspace-8_x
cd .worktree/backport-3065-to-dspace-8_x
git switch --create backport-3065-to-dspace-8_x
git cherry-pick -x 99384a70605b2eccaaae249103673c3735da8c85 61e52cd2abb8ec5dea4b17170e93fe190b086dc9 970b19bf0104a9f361717d148bfc66a60e70e239 446280b59a65c8c0ce24a796ffd14b5eef6eafd0

@tdonohue
Copy link
Member

@alexandrevryghem : Could you manually port either this entire PR, or just the focus indicator fix to 8.x and 7.x? Looks like this cannot be ported automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwoodward nwoodward nwoodward approved these changes

@tdonohue tdonohue tdonohue approved these changes

Assignees

@alexandrevryghem alexandrevryghem

Labels
1 APPROVAL pull request only requires a single approval to merge accessibility bug component: Discovery related to discovery search or browse system port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release themes
Projects
DSpace 9.0 Release
Status: ✅ Done
Milestone
9.0
Development

Successfully merging this pull request may close these issues.

Missing focus indicators
4 participants
@alexandrevryghem @dspace-bot @tdonohue @nwoodward