-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add button to allow free-text editing in the dropdown field of Edit Item #3608
base: main
Are you sure you want to change the base?
Conversation
… edition and fix error when clicking "Clear selection" option
I cherry-picked the commit to DSpace 8 and tested it. It works exactly as expected and it is a very nice solution 👍 |
Could it be easily extended to also apply to hierarchical vocabularies, @toniprieto? |
@MW3000 Yes, it’s possible. I’ve added a new commit to implement it |
Thank you so much @toniprieto. I tested it on DSpace 8 and it works perfectly and is a really elegant UI solution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great and I'm +1 overall, I just wondered if it was worth putting the enabledFreeTextEditing
option into config to it is easier for admins to toggle without having to edit the component itself?
@kshepherd Sorry for the late reply. It shouldn't be necessary to edit the component; |
References
Description
Instructions for Reviewers
Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.
Edit a dropdown field associated with a vocabulary in the Edit Item page (e.g.,
dc.language.iso
ordc.type
), and verify that free-text input can be enabled or disabled using the button shown below, and that uncontrolled values can be saved.Also, verify that clicking the "Clear selection" option clears the content and no longer generates an error in the console.
Checklist
main
branch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lint
npm run check-circ-deps
)package.json
), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.