Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing old name Sherpa Romeo to new name Open Policy Finder #3739

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Andrea-Guevara
Copy link
Contributor

References

Description

Changing from the old name “Sherpa Romeo” to the new name “Open Policy Finder” in the translation files.

Instructions for Reviewers

List of changes in this PR:

  • In the .json5 translation files where the name “Sherpa Romeo” appeared, it was changed to “Open Policy Finder”.

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added bug 1 APPROVAL pull request only requires a single approval to merge integration: Sherpa Romeo Related to integration with Sherpa Romeo i18n / l10n Internationalisation and localisation, related to message catalogs labels Dec 11, 2024
@tdonohue tdonohue added this to the 9.0 milestone Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge bug i18n / l10n Internationalisation and localisation, related to message catalogs integration: Sherpa Romeo Related to integration with Sherpa Romeo
Projects
Status: 🙋 Needs Reviewers Assigned
Development

Successfully merging this pull request may close these issues.

Sherpa Romeo new name and translations
2 participants