Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style compliancy #60

Open
iRon7 opened this issue Aug 20, 2020 · 0 comments
Open

Style compliancy #60

iRon7 opened this issue Aug 20, 2020 · 0 comments

Comments

@iRon7
Copy link

iRon7 commented Aug 20, 2020

Hello Dan,

Your project is great!
I would like to give you some feedback about some styles which I think should be different but before going into detail, I would like to understand which style guide (if any) you using as a lead.
I am aware of two renowned style guides:

I see small discrepancies with your beautifier and the style guides where it concerns spaces around commas and semicolons in collections ($array = @('one', 'two', 'three') is reformatted to: `$array = @('one','two','three')). Which might go a lot deeper with regards to styling and technically (AST relations), e.g.:

  • removing the semicolon at the end of each line (including a HashTable items, as in your own ReadMe.me example)
  • { ,@('test') } where only the left space (between the curly bracket and comma is removed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant