Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New geometry needs changes to reconstruction #166

Open
AsaNehm opened this issue Sep 27, 2024 · 6 comments
Open

New geometry needs changes to reconstruction #166

AsaNehm opened this issue Sep 27, 2024 · 6 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@AsaNehm
Copy link
Contributor

AsaNehm commented Sep 27, 2024

With the new geometry of TMS switching over to 6 modules instead of 4 with then 32 scintillator bars each instead of 48, and in addition the scintillator thickness changing to 17mm instead of 10mm, there are some changes necessary in the reconstruction.
Start of a list of issues and solutions (to be) implemented in a new branch for the future.
!!!No merge onto main while still running on old geometry models!!!

@AsaNehm
Copy link
Contributor Author

AsaNehm commented Sep 27, 2024

TMS_Constants.h

  • different number of planes of thin and thick plates as well as new double plates TMS_nThinPlanes, TMS_nThickPlanes
  • thickness of gap between scintillator increases and new double plate gap is needed TMS_Thin_gap, TMS_Thick_gap
  • scintillator width changes to 17 mm TMS_Scint_Width
  • double steel plate thickness is missing (TMS_Thick_Steel_Width)
  • less bars per module (now 32 instead of 48) nModulesPerSubModule
  • number of planes overall might change to 102 nPlanes

@AsaNehm AsaNehm assigned AsaNehm, LiamOS and jdkio and unassigned AsaNehm Sep 27, 2024
@AsaNehm AsaNehm added the help wanted Extra attention is needed label Sep 27, 2024
@AsaNehm
Copy link
Contributor Author

AsaNehm commented Sep 27, 2024

TMS_TrueParticle.h

  • lines 118 and 135 should reflect the new increased gap as well (more changes here most likely necessary)
    more changes here most likely than just these two lines

@AsaNehm
Copy link
Contributor Author

AsaNehm commented Sep 27, 2024

TMS_Reco.cpp

  • in TrackMatching3D the check for a neighbouring X layer relies on the hardcoded numbers on thin planes and gaps (lines 1234-1239, 1577f, 1601f)

@AsaNehm
Copy link
Contributor Author

AsaNehm commented Sep 27, 2024

Made the necessary changes in TMS_Reco.cpp

@AsaNehm
Copy link
Contributor Author

AsaNehm commented Sep 27, 2024

Adding in the changes in TMS_Constants.h that we already now

@AsaNehm
Copy link
Contributor Author

AsaNehm commented Sep 30, 2024

Changed the number of thick and double steel plates after the decision in the engineering meeting last Friday. Still waiting for official notification of this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants