Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic updating doesn't work for me (Sketch 49.2) #98

Open
eliran-ran opened this issue Apr 4, 2018 · 12 comments
Open

Automatic updating doesn't work for me (Sketch 49.2) #98

eliran-ran opened this issue Apr 4, 2018 · 12 comments

Comments

@eliran-ran
Copy link

Bug report

Expected behavior:

I have a badge with 8px padding (Text + shape layer grouped together). The background layer is named "background [8]".
When changing the text, I would expect the background shape to automatically resize.
"Automatic updating" is turned on.
I'm using Sketch 49.2

Actual behavior:

The background shape will resize only if I run the command "Enter padding for selection" again and again.
I wonder what happened to the amazing "Automatic updating" feature?

@kium-one
Copy link

kium-one commented Apr 4, 2018

Maybe the same issue for me, Paddy "stops" working sometimes.
Here's what the console says :
Error in command main Script at path /Users/xxxxxxxxx/Library/Application Support/com.bohemiancoding.sketch3/Plugins/Paddy.sketchplugin/Contents/Sketch/main.js does not contain a handler function named: selectionChanged.

@Raghav789
Copy link

I think every time a sketch update happens plugin starts to misbehave, fresh installation worked for me
1.un-install the plugin and quit sketch(not just close you need to quit it)
2.Reinstall the plugin

@DWilliames
Copy link
Owner

Yeah I think there's a weird issue within Sketch. Because there definitely is a handler called selectionChanged @najiglass. In the couple of cases I came across it, I just restarted Sketch and re-installed the plugin and it worked. It seems to be an issue with how Sketch caches the plugin I think. 🤔 No too sure. But I don't think there's much I can do.

@eliran-ran The 'automatic updating' feature should definitely still exist.

Either way – just an FYI, I'm in the process of completely re-writing Paddy; which hopefully should take care of a lot of these issues; plus in my first couple of benchmarks the new version seems to be around 30x faster 🔥

Bare with me as I try and bring the new version up to parity, and I promise it will be heaps better.
Thanks for your patience all!

@kium-one
Copy link

kium-one commented Apr 7, 2018 via email

@tschmeisser
Copy link

tschmeisser commented Apr 7, 2018 via email

@eliran-ran
Copy link
Author

Awesome news indeed @DWilliames. Thank you for you efforts!

@DWilliames
Copy link
Owner

@najiglass Thanks 😄
I've begun focusing on nested symbols; and so far I have managed to get it working to some degree. I've got quite a few more kinks to work out. But it's looking promising 👌

@Raghav789
Copy link

Raghav789 commented Apr 10, 2018

@DWilliames it's amazing to hear that you are working on the new plugin but please don't forget your core ideals. I've been working on this huge project for about six months and anima total ruined my spec export.

No special data manipulation: This simply resizes and moves your layers to optimal positions – it doesn't turn your groups into a special 'Stack group' or something; so other people or programs such as Zeplin, can read the Sketch file perfectly fine, without the need for this plugin too.

@kium-one
Copy link

kium-one commented Apr 10, 2018 via email

@Raghav789
Copy link

@najiglass I've tried but instead of reversing or baking only their 'stacks' groups and collapses, they break all groups, removing shapes with no fill and only shadow(I've got a shadow override as a symbol), removing layer blending properties etc. it's very messy.

@DWilliames
Copy link
Owner

@Raghav789 @najiglass – Thanks for the input. I should definitely be able to do it in a way that 'Nested symbols' would be completely optional; so you could toggle it on/off; depending on how important it is to the user. So they can make the decision, given the trade-offs. 👍

@Raghav789
Copy link

@DWilliames I know I extremely simplifying here how about an option to flat/bake/the transformation?which just detaches the symbols till the point of transformation of the nested symbol, since I haven't encountered any such errors so far. then the user can revert back and continue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants