-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic updating doesn't work for me (Sketch 49.2) #98
Comments
Maybe the same issue for me, Paddy "stops" working sometimes. |
I think every time a sketch update happens plugin starts to misbehave, fresh installation worked for me |
Yeah I think there's a weird issue within Sketch. Because there definitely is a handler called @eliran-ran The 'automatic updating' feature should definitely still exist. Either way – just an FYI, I'm in the process of completely re-writing Paddy; which hopefully should take care of a lot of these issues; plus in my first couple of benchmarks the new version seems to be around 30x faster 🔥 Bare with me as I try and bring the new version up to parity, and I promise it will be heaps better. |
Wow that’s incredible news. Thanks for doing this.
Hope you could manage nested symbols as well at some point so I could get rid of Auto-layout (which is so slow) :)
… On Apr 6, 2018, at 7:52 PM, David Williames ***@***.***> wrote:
Yeah I think there's a weird issue within Sketch. Because there definitely is a handler called selectionChanged @najiglass. In the couple of cases I came across it, I just restarted Sketch and re-installed the plugin and it worked. It seems to be an issue with how Sketch caches the plugin I think. 🤔 No too sure. But I don't think there's much I can do.
@eliran-ran The 'automatic updating' feature should definitely still exist.
Either way – just an FYI, I'm in the process of completely re-writing Paddy; which hopefully should take care of a lot of these issues; plus in my first couple of benchmarks the new version seems to be around 30x faster 🔥
Bare with me as I try and bring the new version up to parity, and I promise it will be heaps better.
Thanks for your patience all!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Awesome news @DWilliames. Thanks for the hard work!
…On Sat, Apr 7, 2018 at 6:54 AM najiglass ***@***.***> wrote:
Wow that’s incredible news. Thanks for doing this.
Hope you could manage nested symbols as well at some point so I could get
rid of Auto-layout (which is so slow) :)
> On Apr 6, 2018, at 7:52 PM, David Williames ***@***.***>
wrote:
>
> Yeah I think there's a weird issue within Sketch. Because there
definitely is a handler called selectionChanged @najiglass. In the couple
of cases I came across it, I just restarted Sketch and re-installed the
plugin and it worked. It seems to be an issue with how Sketch caches the
plugin I think. 🤔 No too sure. But I don't think there's much I can do.
>
> @eliran-ran The 'automatic updating' feature should definitely still
exist.
>
> Either way – just an FYI, I'm in the process of completely re-writing
Paddy; which hopefully should take care of a lot of these issues; plus in
my first couple of benchmarks the new version seems to be around 30x faster
🔥
>
> Bare with me as I try and bring the new version up to parity, and I
promise it will be heaps better.
> Thanks for your patience all!
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub, or mute the thread.
>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#98 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AArzZE6HJC6SIgJy3LuDrINJRRd2V7FTks5tmJrtgaJpZM4TG767>
.
|
Awesome news indeed @DWilliames. Thank you for you efforts! |
@najiglass Thanks 😄 |
@DWilliames it's amazing to hear that you are working on the new plugin but please don't forget your core ideals. I've been working on this huge project for about six months and anima total ruined my spec export.
|
I’d say David is a genius and can do better :) In any case it might be worth having an enable/disable nested layers option if we think it might break exports.
Raghav, have you tried with the latest Anima update, they claim to have fixed exports.
… On Apr 10, 2018, at 5:54 AM, Raghav ***@***.***> wrote:
@DWilliames <https://github.com/DWilliames> it's amazing to hear that you are working on new plugin but please don't forget your core ideal. I've been working on this huge project for about six months and anima total ruined my spec export.
No special data manipulation: This simply resizes and moves your layers to optimal positions – it doesn't turn your groups into a special 'Stack group' or something; so other people or programs such as Zeplin, can read the Sketch file perfectly fine, without the need for this plugin too.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#98 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AL_cEsuslX7cwhyHkspxhM5yU1f4qc4Uks5tnIFRgaJpZM4TG767>.
|
@najiglass I've tried but instead of reversing or baking only their 'stacks' groups and collapses, they break all groups, removing shapes with no fill and only shadow(I've got a shadow override as a symbol), removing layer blending properties etc. it's very messy. |
@Raghav789 @najiglass – Thanks for the input. I should definitely be able to do it in a way that 'Nested symbols' would be completely optional; so you could toggle it on/off; depending on how important it is to the user. So they can make the decision, given the trade-offs. 👍 |
@DWilliames I know I extremely simplifying here how about an option to flat/bake/the transformation?which just detaches the symbols till the point of transformation of the nested symbol, since I haven't encountered any such errors so far. then the user can revert back and continue. |
Bug report
Expected behavior:
I have a badge with 8px padding (Text + shape layer grouped together). The background layer is named "background [8]".
When changing the text, I would expect the background shape to automatically resize.
"Automatic updating" is turned on.
I'm using Sketch 49.2
Actual behavior:
The background shape will resize only if I run the command "Enter padding for selection" again and again.
I wonder what happened to the amazing "Automatic updating" feature?
The text was updated successfully, but these errors were encountered: