Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output with directly in line #57

Closed
dukaev opened this issue Feb 12, 2019 · 5 comments
Closed

Output with directly in line #57

dukaev opened this issue Feb 12, 2019 · 5 comments

Comments

@dukaev
Copy link
Contributor

dukaev commented Feb 12, 2019

👋Hi
With this output, we can faster go to files directly in line.
I checked in RubyMine and Sublime Text, Visual Studio Code, also it works in vim.
Output:

code.rb:5 Using each_with_index is slower than while loop.
code.rb:21 Using each_with_index is slower than while loop.
code.rb:37 Enumerable#sort is slower than Enumerable#sort_by.

What do you think about this? If you like it I can do it :)

@DamirSvrtan
Copy link
Owner

Cool, sure thing, wanna make a PR?

@DamirSvrtan
Copy link
Owner

Would be great to support both types of outputting, for consistency sake. So that the output formatter can be configurable. I'm trying to think wether someone depends on the old output.

@dukaev
Copy link
Contributor Author

dukaev commented Feb 13, 2019

I will make PR.
The output will configurable.
.fasterer.yml

display:
  by_lines: true

by_lines will be false by default.

@dukaev dukaev mentioned this issue Feb 13, 2019
@dukaev
Copy link
Contributor Author

dukaev commented Feb 17, 2019

👋 @DamirSvrtan
Can you please review my PR's?

@DamirSvrtan
Copy link
Owner

Merged this in with #64 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants