Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mask_token_ids and update_token_ids API #7

Open
Dan-wanna-M opened this issue Jun 24, 2024 · 1 comment
Open

Add mask_token_ids and update_token_ids API #7

Dan-wanna-M opened this issue Jun 24, 2024 · 1 comment
Assignees
@Dan-wanna-M
Labels
Efficiency The code could be faster enhancement New feature or request

Comments

@Dan-wanna-M
Copy link
Owner

Some users might want to mask an array of token ids(e.g. from top_p, top_k) rather than the whole logits. We probably need the caller to provide an output buffer considering how the FFI works.
@Dan-wanna-M Dan-wanna-M added enhancement New feature or request Efficiency The code could be faster labels Jun 24, 2024
@Dan-wanna-M Dan-wanna-M self-assigned this Jun 24, 2024
@Dan-wanna-M
Copy link
Owner Author

This will essentially stop cache from functioning. Probably should be implemented after eager regex cache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dan-wanna-M Dan-wanna-M

Labels
Efficiency The code could be faster enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Dan-wanna-M