Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

These strings are hardcoded and cannot be translated #9

Open
DAnn2012 opened this issue May 11, 2024 · 4 comments
Open

These strings are hardcoded and cannot be translated #9

DAnn2012 opened this issue May 11, 2024 · 4 comments

Comments

@DAnn2012
Copy link
Contributor

Hello @Dan0sz

These strings are hardcoded and cannot be translated:

const CAOS_ADMIN_ALLOW_TRACKING_OPTIONS = [
'' => 'Always (default)',
'cookie_is_set' => 'When cookie is set',
'cookie_is_not_set' => 'When cookie is NOT set',
'cookie_has_value' => 'When cookie has a value (exact match)',
'cookie_value_contains' => 'When cookie value contains (loose comparison)',
'consent_mode' => 'When Consent Mode\'s <code>analytics_storage</code> property is updated to "granted" by another plugin',
];
const CAOS_ADMIN_TRACKING_CODE_OPTIONS = [
'' => 'Asynchronous (default)',
'minimal_ga4' => 'Minimal Analytics 4',
];
const CAOS_ADMIN_SCRIPT_POSITION_OPTIONS = [
'header' => 'Header (default)',
'footer' => 'Footer',
'manual' => 'Add manually',
];

Thanks.

@DAnn2012
Copy link
Contributor Author

Hi @Dan0sz

please could you kindly take a look at this my Issue report?

Thank you.

@Dan0sz
Copy link
Owner

Dan0sz commented Jul 17, 2024

It's on my todo list. Thanks for notifying me!

@DAnn2012
Copy link
Contributor Author

Hi @Dan0sz

I would like to point out that those strings are hardcoded even in the latest version 4.8.2.

Thanks.

@Dan0sz
Copy link
Owner

Dan0sz commented Dec 2, 2024

Yes, quite a few refactors are required (as it's a constant, containing the strings) to make them translatable. And I haven't gotten around to that yet. Feel free to make a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants