Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display custom nicknames in Draw Full Names mode #16

Open
MaximeCouty opened this issue Feb 15, 2023 · 2 comments
Open

Display custom nicknames in Draw Full Names mode #16

MaximeCouty opened this issue Feb 15, 2023 · 2 comments

Comments

@MaximeCouty
Copy link

Hi Daniel,

Small glitch that I noticed when playing with this plugin.
In Draw Full Names mode (which I use), the display custom nicknames only works for components that have identical Names and Nicknames.

Example below with Partition List whose nickname is Partition, but displayed as Partition List when GH is in draw full names mode.

image

I had a look at the code and I'm not sure if this is sufficient, but maybe the nickname should be also compared to the name of the component to determine is the filtering has to occur or not.

@DanielAbalde
Copy link
Owner

Hi there, thanks for the notice.

Partition is the default nickname of Partition List, so it's not a "custom" or user-defined nickname, that's why it's not displayed when Display only custom nicknames is active. You can solve this by including a whitespace at the end or start, for example Partition .

@MaximeCouty
Copy link
Author

Yes, I noticed that, but actually what I would like is that Partition List does NOT show on top of the component.
From what I understand the Draw Full Names mode overrides the nickname and puts the name instead, though the default Nickname is unchanged. What I'm suggesting is that Sunglasses should compare to the name and the nickname, and if either is a match, then the text display is disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants