Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of auth expires #110

Open
scaspers opened this issue Apr 30, 2018 · 4 comments
Open

Better handling of auth expires #110

scaspers opened this issue Apr 30, 2018 · 4 comments
Assignees
Labels
App Infrastructure Structural investment for features, but not directly a feature Design Planning and strategy for how to accomplish tasks

Comments

@scaspers
Copy link
Collaborator

What seems to happen is when the auth is expired the page errors with a stack trace.

Expected:
Page should be redirected to the login page.

@DanielCaspers
Copy link
Owner

Screenshot please

@DanielCaspers DanielCaspers added this to the v1.1 milestone Apr 30, 2018
@scaspers scaspers added the Cannot Reproduce The assignee is unable to witness the same issue in their own independent testing label May 1, 2018
@scaspers
Copy link
Collaborator Author

scaspers commented May 1, 2018

Looked into where the Apps auth timeout was. It was set yo 5hrs and I changed it to 10hrs. After talking with @DanielCaspers I think the app 's cookie is set to 10hrs so this should sync the systems and correct the behavior for now. I'll leave this open for a 1-2 weeks and see what happens.

@DanielCaspers DanielCaspers modified the milestones: v1.1, V1.2 May 4, 2018
@DanielCaspers DanielCaspers modified the milestones: V1.2, v1.3 Sep 8, 2018
@DanielCaspers DanielCaspers self-assigned this Oct 16, 2018
@DanielCaspers DanielCaspers added Design Planning and strategy for how to accomplish tasks App Infrastructure Structural investment for features, but not directly a feature and removed Cannot Reproduce The assignee is unable to witness the same issue in their own independent testing labels Oct 16, 2018
@DanielCaspers
Copy link
Owner

@scaspers Here's an example of the current flow within an Angular + ASP.NET Core App. MP4 file is in ZIP.

Current limitations

  • No refresh tokens
  • I'm issuing the tokens, not you
  • No auth redirect

AuthDemo_v1.zip

@DanielCaspers DanielCaspers removed this from the v1.3 milestone Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App Infrastructure Structural investment for features, but not directly a feature Design Planning and strategy for how to accomplish tasks
Projects
None yet
Development

No branches or pull requests

2 participants