-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
punycode depreciation #5
Comments
@britkat1980 - I've made this pull request: britkat1980/giv_tcp#259. This is to replace the I also fixed the I did a test build of GivTCP image locally, and the web dashboard renders with |
Thanks, that's working, but I get a different depreciation error: (node:63) [DEP0066] DeprecationWarning: OutgoingMessage.prototype._headers is deprecated There's couple of tweaks needed to work with GivTCP v3, but I'll create a PR back with that shortly. |
Is there any need to use node at runtime at all? If nginx can be used to serve the static site instead that removes the need to have node/npm in the runtime image completely and knocks a few hundred MB off the size. I knocked up a quick prototype locally - happy to PR if there's interest. |
Always happy to slim down the image size. Send a PR over on the GivTCP repo |
The dashboard just needs something simple to render the static web content. @willholley your approach sounds good. Thanks! |
Great - I filed a PR at britkat1980/giv_tcp#283 |
v3 of GivTCP uses Alpine3.19 and is now giving a depreciation warning for punycode module:
The text was updated successfully, but these errors were encountered: