Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP - dot completion #1559

Open
zolomatok opened this issue Nov 1, 2024 · 4 comments
Open

LSP - dot completion #1559

zolomatok opened this issue Nov 1, 2024 · 4 comments
Labels
lsp Language Server Protocol or other VSCode issues

Comments

@zolomatok
Copy link
Contributor

A small (?) request for the VSC extension.
I would love for method discovery to be as great as in a plain TS file.

In typescript, if I type a dot after an object, it shows me its properties and methods. It also shows the documentation.

In civet, I get neither at the moment. Code completion does work if you know what you're looking for, but you don't get documentation in any case.

(The video tests with imported files, but the behaviour is the same for locally defined objects)

dot.mov

I'm running the VSC plugin version 0.3.24.

tsconfig

{
    "compilerOptions": {
        "module": "es2022"
        "target": "es2022"
        "moduleResolution": "bundler"
    }
}
@edemaine edemaine added the lsp Language Server Protocol or other VSCode issues label Nov 1, 2024
@edemaine
Copy link
Collaborator

edemaine commented Nov 1, 2024

We've been discussing the . feature possibility recently. My first attempt (#1560) hasn't worked so far.

I hadn't noticed the documentation issue. This was actually a TODO in the LSP source code, which will mostly be resolved by #1561. Thanks for suggesting looking into this!

@edemaine
Copy link
Collaborator

edemaine commented Nov 2, 2024

Update: You can give the VSCode extension v0.3.25 a try; it should give documentation, at least in most cases. (In others, it gives an error. Still some tracking down to do.)

@zolomatok
Copy link
Contributor Author

Oooh, the documentation does work now, great work @edemaine, thank you!

@zolomatok
Copy link
Contributor Author

Super nice to hear the dot completion is being worked on as well. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lsp Language Server Protocol or other VSCode issues
Projects
None yet
Development

No branches or pull requests

2 participants