Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Disabled request header still appears in the report #437

Open
1 task done
chrisleves opened this issue Jun 26, 2024 · 2 comments
Open
1 task done
Labels
state: triaged This issue has been triaged type: enhancement New feature or request

Comments

@chrisleves
Copy link

Is There An Existing Issue

What Are You Seeing

Postman source file in the request header section:

				{
					"key": "X-TestMode",
					"type": "text",
					"value": "dummy-return-without-brms-api-call",
					"disabled": true
				}

image

Steps To Reproduce The Issue

Add any disabled request headers in your postman tests and run the html reporter extra.

Full Newman Command Or Node Script

N/A

HTMLEXTRA Version

1.22.5

Newman Version

5.2

Additional Context

No response

@chrisleves chrisleves added state: needs-triage This issue needs to be triaged type: bug Something isn't working labels Jun 26, 2024
Copy link

Hey @chrisleves: 👋 - Thanks for helping to make the reporter better by raising this ticket. I will take a look as soon as I can and get back to you. Cheers, Danny.

@DannyDainton DannyDainton changed the title Disabled request header still appears in the report ! Disabled request header still appears in the report Jun 26, 2024
@DannyDainton DannyDainton changed the title Disabled request header still appears in the report [Feature Request] Disabled request header still appears in the report Jun 27, 2024
@DannyDainton DannyDainton added type: enhancement New feature or request state: triaged This issue has been triaged and removed type: bug Something isn't working state: needs-triage This issue needs to be triaged labels Jun 27, 2024
@DannyDainton
Copy link
Owner

Hey @chrisleves

There isn't anything in the reporter that filters those out in that way.

We have the flag to skip a specific header:

newman run collection.json -r htmlextra --reporter-htmlextra-skipHeaders "Authorization"

This is all based on the name of the header and it doesn't automatically look at any properties in the header object to check for the disabled boolean.

Feel free to make this change and raise a PR if you'd like to add it in there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: triaged This issue has been triaged type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants