Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Messages shown by emotes are only shown client-side #1342

Open
3 tasks done
jadebenn opened this issue Dec 18, 2023 · 1 comment
Open
3 tasks done

BUG: Messages shown by emotes are only shown client-side #1342

jadebenn opened this issue Dec 18, 2023 · 1 comment
Labels
bug Something isn't working P-Fixer This issue is confirmed, but is not prioritized to be fixed.

Comments

@jadebenn
Copy link
Collaborator

Make sure you've done the following:

  • I have checked that this issue has not already been reported.

  • I have validated that this issue is not a syntax error of either MySQL or SQLite.

  • I have pulled the latest version of the main branch of DarkflameServer and have confirmed that the issue exists there.

DarkflameServer Version

e239166

Issue Description

When playing an emote, the animation is shown to other players, but emotes that play messages do not show any messages to other players.

Reproduction Steps

  1. Get two players
  2. Have one play an emote that should show a message
  3. Observe the other player cannot see any message

Expected Behavior

Other players should see a message above other players' heads when they play an emote that displays one.

Environment

WSL

@jadebenn jadebenn added bug Something isn't working triage An issue that needs triage labels Dec 18, 2023
@EmosewaMC EmosewaMC added P-Fixer This issue is confirmed, but is not prioritized to be fixed. and removed triage An issue that needs triage labels Dec 18, 2023
@aronwk-aaron
Copy link
Member

I think this has something to do with chat messages and the local_emote channel.
I'm not sure if that even sends a chat message to the server for it and we just ignore it cause of the channel it comes in on, or if we should just know to send the chat from the emote GM that the server receives

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P-Fixer This issue is confirmed, but is not prioritized to be fixed.
Projects
None yet
Development

No branches or pull requests

3 participants