Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug // 1.18.2 - 8.1.32] High Tick Usage from Pots #418

Closed
FocalFlare opened this issue Aug 18, 2024 · 4 comments
Closed

[Bug // 1.18.2 - 8.1.32] High Tick Usage from Pots #418

FocalFlare opened this issue Aug 18, 2024 · 4 comments
Labels
question A question about the project.

Comments

@FocalFlare
Copy link

Question

Initial Observation

I feel like I may ask something stupid, so let me ask it at the end and leave you with this:

While using the botany pots in one of my worlds, I noticed that, via Observable, they were taking up a lot of ticks in the world over everything else. So I went into one of my test worlds to do some testing with both the hopper and the regular pots--which I labeled as red and yellow--and proceeded to profile their tick usage with observable. I noticed that the hopper pots use a small amount of ticks when idling, and a crap ton of ticks (exaggeration, I know) when they either have anything in their inventories or are doing something.

Testing

The following tests were done using the profiling mod Observable. The most recent profile I saved in the screenshot for the pots being active focuses on only these two pots, but the full profile for the entire world is here:
2024-08-18--01.20.09.json

Active Growth

Here's the tick usage (in us/t) on the pots not doing anything (again, yellow = hopper and red = regular). This is the "reference profile".
2024-08-18_01 15 16

And the tick usage on them while they grow crops.
2024-08-18_01 16 25

No Crops in Pots

Here's what the tick usage of the pots is like when there are only crops in each pot.
image

No Soil in Pots

Same deal, but this time there's no required soil in each pot.
image

Question

Again, probably a stupid question because I feel like I'm missing something here, but is this intended or is this something to be looked into? I know I should've opened this as a bug issue, but I'm not too sure whether it's either a bug or it's actually meant for the hopper pot to cause high tick usages like this.

Game Info (related to this issue only)

  • Minecraft version: 1.18.2
  • Forge version: 40.2.21
  • Mod version: 8.1.32
  • Observable version: 2.2.3
@FocalFlare FocalFlare added the question A question about the project. label Aug 18, 2024
@FocalFlare FocalFlare changed the title [QUESTION] High Tick Usage from Pots [Bug // 1.18.2 - 8.1.32] High Tick Usage from Pots Sep 9, 2024
@FocalFlare
Copy link
Author

FocalFlare commented Sep 9, 2024

Not sure if @Darkhax is already aware of this or not, but I changed "Question" in the title to "Bug" since—after enough time of inactivity on this issue within the last 3 weeks of it being open—I've came to the conclusion that this seems to be something that's not supposed to be intended more than something that is to be intended.

@FocalFlare
Copy link
Author

@Darkhax This issue will be made again at some point, but feel free to reopen this issue if you have any ideas on this one. I will shelf this issue will for now due to there being no response.

@FocalFlare FocalFlare closed this as not planned Won't fix, can't repro, duplicate, stale Oct 1, 2024
@Darkhax
Copy link
Member

Darkhax commented Oct 2, 2024

Hey, sorry for not replying sooner. I haven't been very active the last few weeks because I have been dealing with some personal stuff. The results you have shared are very interesting and I would be open to looking into them. A few issues related to inventory updates have been found and that is likely partly responsible for the lag you're seeing. #421

@FocalFlare
Copy link
Author

Just looked at some of the info in #421 (made 3 issues after this one). Sadly I don't think I know what else other than serving as a backbone for select mods that Bookshelf does, so I wouldn't really know of the things that it's doing. Surprisingly the OP of #421 discovered that as the cause.

They also seemed to have brought up an add-on Botany Pots Tiers which I've been using myself, but I've never had issues with that alone if any, oddly enough. I also noticed that they made an add-on that fixes said issue, but at the moment it's for Fabric 1.20.1 (it's in beta so I can't really expect a lot lol).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question A question about the project.
Projects
None yet
Development

No branches or pull requests

2 participants