Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Armor #796

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Armor #796

wants to merge 4 commits into from

Conversation

WWWWW-Git
Copy link
Contributor

@WWWWW-Git WWWWW-Git commented Sep 25, 2024

About The Pull Request

This PR adds a whole bunch of new armors to the game. Most of them can be obtained via crafting/smithing but there are a few standouts that can only be obtained via an admin spawn.
1
Slit kettle: Obtained by smithing, essentially a reskin of the kettle helmet.
2
Halfvisor: Obtained by smithing, reskin of the sallet but with nose protection.
3
Klappvisor: Obtained by smithing, hounskull reskin.
65
Gilded Helmet: Obtained by smithing.
331
Sunhelm: Obtained by smithing, requires 2 golden ingots. But surely its a price Astratan fanatics can afford.
3315
Xylix Hood: Can only be obtained via an admin spawning it in.
5317
Fanatic Hood: Can only be obtained via an admin spawning it in.
7567
Beakhelm: Obtained by smithing, reskinned Noc helm.
8867
Totod Helmet: Only obtainable by an admin spawning it in.
22157
Grenzel Hounskull: Can only be obtained by an admin, reskinned hounskull but doesn't have visor functionality, instead has a function allowing it to be right clicked so that the plume color can be changed much like how the rest of the Grenzel clothes detail can be changed.
11564
Boggard Hauberk: Can be obtained by crafting. A reskinned iron chainmail, can be acquired by crafting an iron chainmail, clod of dirt, stick, and fiber.
67865
Bog Cowl: Can be obtained by crafting. Requires a dirtclod, fibers, and stick to create.

Why It's Good For The Game

I feel these new armors will allow for more roleplay potential for players.

  • You tested this on a local server.
  • This code did not runtime during testing.
  • You documented all of your changes.

@ThePainkiller
Copy link
Contributor

Can you attach in game screenshots or at least photos that are a biiiiiiiiit less zoomed in?

@WWWWW-Git
Copy link
Contributor Author

Can you attach in game screenshots or at least photos that are a biiiiiiiiit less zoomed in?

These are the only screenshots I have.

@ThePainkiller ThePainkiller added the Icons This PR adds, edits or deletes icons label Sep 26, 2024
@ThePainkiller
Copy link
Contributor

ThePainkiller commented Sep 26, 2024

I'm sorry to say, but these are definitely not up for our sprites' standards, the halfvisor could also do some work, I suggest consulting with the spriting team about how to resprite these ones.

Icons

@WWWWW-Git
Copy link
Contributor Author

I'm sorry to say, but these are definitely not up for our sprites' standards, the halfvisor could also do some work, I suggest consulting with the spriting team about how to resprite these ones.

Icons

Heres what im gonna do im gonna consult with Dromkii and then im gonna make new icons for the tricksterhood, sunhelm and beakhelm and im gonna do some work on the halfvisor icon okay

@WWWWW-Git
Copy link
Contributor Author

Ok sir there you go all patched up.

@NPC1314 NPC1314 added the Merge conflict This PR won't compile due to merge conflics label Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Icons This PR adds, edits or deletes icons Merge conflict This PR won't compile due to merge conflics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants