diff --git a/scripts/globals/caskets.lua b/scripts/globals/caskets.lua index d4faace37aa..66bbaabe439 100644 --- a/scripts/globals/caskets.lua +++ b/scripts/globals/caskets.lua @@ -4542,25 +4542,27 @@ local function dropChance(player) ----------------------------------------------------------------------------------------- -- NOTES: 10% base drop rate. -- Super Kupowers(Myriad Mystery Boxes) adds 10% drop rate to the base rate. - -- GoV Prowess Increased Treasure Casket Discovery adds 5% per level (max 5 levels) - -- for a total of 25% increase. -- NOTE this needs to be confirmed! + -- GoV Prowess Increased Treasure Casket Discovery adds 1% per level (max 5 levels) + -- This should be max 5 levels but its 11 right now - Teo says the regimes global needs fixing ----------------------------------------------------------------------------------------- - --local kupowerMMBEffect = player:getStatusEffect(dsp.effect.KUPOWERS_MYRIAD_MYSTERY_BOXES) -- Super Kupowers Myriad Mystery Boxes not implimented yet. + local baseCasketRate = 101 power = 1% + local kupowerMMBEffect = 0 -- not implemented: player:getStatusEffect(dsp.effect.KUPOWERS_MYRIAD_MYSTERY_BOXES) local casketProwessEffect = player:getStatusEffect(dsp.effect.PROWESS_CASKET_RATE) local kupowersMMBPower = 0 local prowessCasketsPower = 0 - --if player:hasStatusEffect(dsp.effect.KUPOWERS_MYRIAD_MYSTERY_BOXES) then -- Super Kupowers Myriad Mystery Boxes not implimented yet. - -- kupowersMMBPower = kupowerMMBEffect:getPower() - --end + --[[ Super Kupowers Myriad Mystery Boxes not implimented yet. + if player:hasStatusEffect(dsp.effect.KUPOWERS_MYRIAD_MYSTERY_BOXES) then + kupowersMMBPower = kupowerMMBEffect:getPower() + end + ]] if player:hasStatusEffect(dsp.effect.PROWESS_CASKET_RATE) then prowessCasketsPower = casketProwessEffect:getPower() end - local rand = math.random() - - if rand < utils.clamp(CASKET_DROP_RATE + kupowersMMBPower + prowessCasketsPower, 0, 1) then + local rand = math.random(100) + if rand < (baseCasketRate + kupowersMMBPower + prowessCasketsPower) then return true end diff --git a/scripts/globals/regimes.lua b/scripts/globals/regimes.lua index c2a3895ac8e..46c0f7bb4b5 100644 --- a/scripts/globals/regimes.lua +++ b/scripts/globals/regimes.lua @@ -1259,6 +1259,12 @@ dsp.regime.checkRegime = function(player, mob, regimeId, index, regimeType) reward = math.floor(reward * avgCapLevel / avgMobLevel) end + --[[ + This whole thing needs to die and be redone. The prowess effects do not all have the samestack cap of 11. + The one for casket rate caps at 5 stacks for example. see https://ffxiclopedia.fandom.com/wiki/Grounds_of_Valor#Prowesses + Additionaly forget this if/elseif crap this needs a table. + It was ok back when it was only 3 effects but to get all of them this needs changed. + ]] -- prowess buffs from completing Grounds regimes if regimeType == dsp.regime.type.GROUNDS then local prowess = math.random(dsp.effect.PROWESS_CASKET_RATE, dsp.effect.PROWESS_KILLER)