Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo Command needs to be typed twice to undo editing and deleting of contact details #2

Open
Darren159 opened this issue Nov 17, 2023 · 1 comment

Comments

@Darren159
Copy link
Owner

Darren159 commented Nov 17, 2023

The undo command only works to undo editing and deleting of contact details only after 2 inputs.

Steps to reproduce:

  1. Edit/Delete a contact detail
  2. Enter undo command
  3. Enter undo command again

Expected:
undo command should undo the edit/delete on the first input

Actual:
undo command only works after the second input, first input has no visible change

image.png
Initial State

image.png
image.png
Edited

image.png
image.png
No change on first time input of undo command

image.png
image.png
Undo only works on second input

@nus-pe-bot
Copy link

nus-pe-bot commented Nov 20, 2023

Team's Response

Spot on! It in fact requires two undo commands to undo an edit or a delete command. There are in fact 2 different bugs here:

  • Undo does not work with edit command.
  • Undo does not work with delete command.

We would group this bug report together with reports on undo not working for delete command.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Undo/redo command pair is erronenous for a multitude of functions

image.png
after deleting phone number from 3 and undoing, nothing happens even though success message is given.
redoing said undo does not do anything.

image.png
after deleting email from 3 and undoing, nothing happens even though success message is given.
redoing said undo does not do anything.
same for /link, /grad, /course ( basically all fields for person).redoing said undo does not do anything.


[original: nus-cs2103-AY2324S1/pe-interim#2611] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

We acknowledge that this is a bug in our programme. There are actually two separate bugs here:

  • Undo does not work if last command is edit.
  • Undo does not work if last command is delete.

We would group this bug report together with reports on undo command not working with delete command.

Items for the Tester to Verify

❓ Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

  • I disagree

Reason for disagreement: [replace this with your explanation]


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants