Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent naming for phone field #7

Open
Darren159 opened this issue Nov 17, 2023 · 1 comment
Open

Inconsistent naming for phone field #7

Darren159 opened this issue Nov 17, 2023 · 1 comment

Comments

@Darren159
Copy link
Owner

Darren159 commented Nov 17, 2023

In the Fields table, the field is named phone numbers but when it is used in other sections below, phones is used which is inconsistent with other fields which use the full name like graduation semester.

image.png

image.png

@nus-pe-script
Copy link

nus-pe-script commented Nov 20, 2023

Team's Response

First, there are no short forms for graduation semester, so we use the full form.

Second, phones and phone numbers mean the same thing here, there is no ambiguity and hence it should not hinder the reader.

Items for the Tester to Verify

❓ Issue response

Team chose [response.Rejected]

  • I disagree

Reason for disagreement: Fields such as graduation semester and specialisations can be shortened to grad sem or specs, however the team might have chosen not to use them which is fine. However, it is consistent in the usage. Furthermore, phones and phone numbers mean two different things, ie the phone object itself and the number.

However, I do agree that while it might not hinder the reader, it is still a grammar/consistency error which still warrants a bug and should not be Rejected as it can be further improved.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants