Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Google Drive API v3 everywhere #55

Open
DarthVanger opened this issue Dec 25, 2019 · 0 comments
Open

Use Google Drive API v3 everywhere #55

DarthVanger opened this issue Dec 25, 2019 · 0 comments
Milestone

Comments

@DarthVanger
Copy link
Owner

DarthVanger commented Dec 25, 2019

Some methods in google-drive-api.js/noteStorageAPI.js use Google Drive API v3, but some use v2.

For example, function getTextFileContents in noteStorageAPI.js uses Google Drive API v3:
https://github.com/DarthVanger/NeuralNotes/blob/master/src/storage/noteStorageAPI.js#L329

  const request = gapi.client.request({
    path: '/drive/v3/files/' + requestParams.fileId,

While function updateFileName in google-drive-api.js uses Google Drive API v2
https://github.com/DarthVanger/NeuralNotes/blob/master/src/api/google-drive-api.js#L119

  let request = gapi.client.request({
    'path': '/drive/v2/files/' + fileId,

Go through all the methods and switch from Google Drive API v2 to v3 everywhere.

See the article about v2 vs v3 differences: https://developers.google.com/drive/api/v2/v3versusv2

@DarthVanger DarthVanger added this to the v0.2 - refactoring milestone Jan 9, 2020
@kvoncode kvoncode self-assigned this Oct 29, 2020
@kvoncode kvoncode removed their assignment Nov 19, 2020
@DarthVanger DarthVanger modified the milestones: v0.2 - refactoring, v1.1 Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants