Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Longer life for batteries #285

Closed
micmarluc opened this issue Dec 14, 2022 · 12 comments
Closed

Longer life for batteries #285

micmarluc opened this issue Dec 14, 2022 · 12 comments
Labels
enhancement New feature or request

Comments

@micmarluc
Copy link

micmarluc commented Dec 14, 2022

The problem you're addressing (if any)
Currently, it is not possible to limit the battery charge when the computer is plugged into the mains (for all users)

Describe the solution you'd like
Add a firmware option (if possible) to limit the battery charge for example to 80% - with the possibility to go back to 100% if necessary.

Where is the value to a user, and who might that user be?
More savings and less pollution for everyone

Describe alternatives you've considered

Additional context

@macpijan
Copy link
Contributor

Hello @micmarluc
Thanks for the report. It would be nice to provide more details on what device are you referring to.
I assume it is one of the NovaCustom laptops.

@micmarluc
Copy link
Author

Hello @macpijan
Sorry for forgetting !
Indeed, it is a NovaCustom laptop : NS70.

@micmarluc
Copy link
Author

Hello @macpijan
1/ More details about my laptop : NovaCustom NS70MU i5-1135G7
2/ Please, can you add the label "enhancement", I did not understand how to do it. I searched in the GitHub documentation (managing labels), but I can’t find any right sidebar that gives me access to the settings. Thank you

@pietrushnic pietrushnic added the enhancement New feature or request label Jan 29, 2023
@pietrushnic
Copy link

@micmarluc I guess that only organization members can add labels.

@UndeadDevel
Copy link

This seems like a duplicate of #246 but FWIW having this option is indeed very much desired; I'm using Heads from NitroKey and on their 2.1 release (~June 2023) the system exposed /sys/class/power_supply/BAT0/charge_control_end_threshold and /sys/class/power_supply/BAT0/charge_control_start_threshold, which allowed to manually set the charge limits. Now I upgraded to version 2.4 (based on coreboot 1.7.2) and those files have disappeared such that now there doesn't seem to be the possibility of setting charge limits any more.

@pietrushnic
Copy link

Now I upgraded to version 2.4 (based on coreboot 1.7.2) and those files have disappeared such that now there doesn't seem to be the possibility of setting charge limits any more.

Currently, we do not support Dasharo (coreboot+Heads) on Novacustom. Saying that issues regarding Nitrokey releases should go to the Nitrokey repository.

Of course, we are working on enabling Dasharo (coreboot+Heads) and hope to deliver this month. I'm not sure what else we can do right now. @macpijan cc

@UndeadDevel
Copy link

Ok, I already reported it at their issue tracker; I just thought that this is probably an upstream issue with coreboot, but I could be wrong about that.

@wessel-novacustom
Copy link

This has been developed now, I think the issue can be closed. @macpijan

@wessel-novacustom
Copy link

@micmarluc The feature has been implemented. Could you close the issue, please?

@tlaurion
Copy link

tlaurion commented Apr 22, 2024

@macpijan @wessel-novacustom closed too soon? Seems like EC not discovered by coreboot with system76_acpi kernel driver not loading, so BAT0 thresholds not avail me for tlp? Not sure what Heads can do here.

linuxboot/heads#1647 (comment)

@tlaurion
Copy link

Should reopen until #820 fixed

@macpijan
Copy link
Contributor

macpijan commented Apr 25, 2024

It was implemented in the firmware (edk2 talking to EC) for the UEFI firmware variant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants