-
Notifications
You must be signed in to change notification settings - Fork 1
Allow users to connect their social accounts after they have signed up #53
Comments
@eddiejaoude Thinking about this feature, Could you please let me know your thoughts on the following scenario?
|
@VenkatVenkatesh also note the discussion on #56 (comment) regarding this |
This would be treated like a new account and related docs - I think this would be easier, but please correct me if I am wrong. The easiest option for this. |
@eddiejaoude The problem with the above approach is the userId returned by the firebase will be same in both the scenarios. So It will cause duplication of documents. The easiest approach would be converting the primary account to the secondary one if it doesn't have any other accounts connected to it and we should a error prompt if they try adding a primary account that has accounts linked to it as secondary to some other account. Could you please let me know what's your thought on the above approach ? |
Converting accounts sounds like a lot of work. Can we throw an error page and say this is not your primary account and display them a button to login with for their primary account? Would this be easier? |
That's sounds good. Thank you 👍 |
No problem 👍 |
Hi @eddiejaoude, let me know your thoughts on the below approach
|
I think it would be easier to store the main Can you share the whole model structure (in |
Okay @eddiejaoude . Will create and share it. |
@eddiejaoude We can do like the above approach. but I think there will be increased complexity when handling the following scenario. If the user logsIn in with github as primary account and links youtube and twitter , the user dashboard will now render the data's of github, youtube and twitter. I have a question here, Could you please let me know if the user is allowed to login through their linked accounts. If yes, then we need to find the primary account details for the linked accounts and also we have to find that whether that primary account has any other linked accounts. I think we have to do two-way join for this scenario. Could you please let me know your thoughts on this ? |
The user is not allowed to log in via their linkedin accounts, thats why I think its simpler but if there are other reasons let me know. We previously discussed in the teams section a structure similar to ... User {
// ...
socialConnections: [
twitter: { ... },
youtube: { ... }
// ...
]
} So in the user table we know immediately which is the account they logged in with and which are connected accounts. May be something has changed? @SrijithRad what do you think? |
That makes sense @eddiejaoude . So to arrive at a conclusion,
|
Sounds good 👍 |
Thank you 😄 |
Looks good @eddiejaoude |
Connect with Twitter
andConnect with Github
buttons on the cards depending on what account they used to sign up.Github
, show theConnect with Twitter
button and vice versaGithub
andTwitter
The text was updated successfully, but these errors were encountered: