chore(fleet): Add "direct" RC option to pull configurations #30369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BaptisteFoy
added
changelog/no-changelog
qa/done
BaptisteFoy
force-pushed
the
baptiste.foy/FA/direct-cdn
branch
5 times, most recently
from
2f7e27f to
1cf34c0
Compare
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=48229887 --os-family=ubuntuNote: This applies to commit 65055a5 |
Regression Detector |
BaptisteFoy
force-pushed
the
baptiste.foy/FA/direct-cdn
branch
2 times, most recently
from
fa48009 to
fb6d460
Compare
BaptisteFoy
force-pushed
the
baptiste.foy/FA/direct-cdn
branch
from
fb6d460 to
8c3db2f
Compare
BaptisteFoy
force-pushed
the
baptiste.foy/FA/direct-cdn
branch
3 times, most recently
from
4ff2b35 to
7b2a73b
Compare
BaptisteFoy
force-pushed
the
baptiste.foy/FA/direct-cdn
branch
from
7b2a73b to
3de4c3d
Compare
BaptisteFoy
force-pushed
the
baptiste.foy/FA/direct-cdn
branch
from
c507b5a to
c0105d5
Compare
github-actions
bot
added
long review
BaptisteFoy
force-pushed
the
baptiste.foy/FA/direct-cdn
branch
from
c0e3b7c to
2ee54f3
Compare
github-actions
bot
added
medium review
BaptisteFoy
force-pushed
the
baptiste.foy/FA/direct-cdn
branch
2 times, most recently
from
c965507 to
69d8d9a
Compare
BaptisteFoy
force-pushed
the
baptiste.foy/FA/direct-cdn
branch
from
69d8d9a to
fd50c3f
Compare
coignetp
approved these changes
Nov 4, 2024
mellon85
reviewed
Nov 5, 2024
mellon85
reviewed
Nov 5, 2024
github-actions
bot
added
long review
mellon85
approved these changes
Nov 5, 2024
|
/merge |
|
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Real CDN is still WIP so we need another reliable option to pull config: this PR adds a regular RC client to do so. It also adds an option to use the real CDN that is disabled by default
Motivation
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes
Config field to allow CDN use in the daemon will come in another PR