Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test-infra-definitions][automated] Bump test-infra-definitions to 0269b182e897cdaea4df7d9658036585932ecabe #30808

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

agent-platform-auto-pr[bot]
Copy link
Contributor

This PR was automatically created by the test-infra-definitions bump task.

This PR bumps the test-infra-definitions submodule to 0269b182e897cdaea4df7d9658036585932ecabe from 0a48ed729822.
Here is the full changelog between the two commits: DataDog/test-infra-definitions@0a48ed7...0269b18

⚠️ This PR is opened with the qa/no-code-change and changelog/no-changelog labels by default. Please make sure this is appropriate

@agent-platform-auto-pr
Copy link
Contributor Author

agent-platform-auto-pr bot commented Nov 6, 2024

[Fast Unit Tests Report]

On pipeline 48430226 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

Copy link

cit-pr-commenter bot commented Nov 6, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: ea61889a-0d85-450d-8f72-bf27245a4c5f

Baseline: de82921
Comparison: 627d22d
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
basic_py_check % cpu utilization +3.15 [-1.01, +7.31] 1 Logs
quality_gate_idle_all_features memory utilization +1.29 [+1.18, +1.40] 1 Logs bounds checks dashboard
pycheck_lots_of_tags % cpu utilization +0.60 [-2.96, +4.15] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.05 [-0.15, +0.25] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.01 [-0.33, +0.34] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.00 [-0.27, +0.26] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.01 [-0.25, +0.23] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.08, +0.07] 1 Logs
idle_all_features memory utilization -0.08 [-0.17, +0.02] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency egress throughput -0.15 [-0.64, +0.34] 1 Logs
file_tree memory utilization -0.29 [-0.42, -0.16] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.36 [-0.40, -0.32] 1 Logs
quality_gate_idle memory utilization -0.36 [-0.41, -0.31] 1 Logs bounds checks dashboard
idle memory utilization -0.39 [-0.44, -0.34] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api_cpu % cpu utilization -1.25 [-1.99, -0.52] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_100ms_latency lost_bytes 3/10
file_to_blackhole_0ms_latency lost_bytes 9/10
quality_gate_idle_all_features memory_usage 9/10 bounds checks dashboard
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
idle memory_usage 10/10 bounds checks dashboard
idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@pducolin pducolin requested review from a team as code owners November 7, 2024 09:27
@github-actions github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Nov 7, 2024
Copy link
Contributor

@BaptisteFoy BaptisteFoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for FA tests

@agent-platform-auto-pr
Copy link
Contributor Author

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=48430226 --os-family=ubuntu

Note: This applies to commit 627d22d

@pducolin
Copy link
Contributor

pducolin commented Nov 7, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 7, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-11-07 16:28:55 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2024-11-07 16:29:59 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 24m.

@dd-mergequeue dd-mergequeue bot merged commit 80ece75 into main Nov 7, 2024
371 checks passed
@dd-mergequeue dd-mergequeue bot deleted the auto-bump/bump-test-infra-0269b182 branch November 7, 2024 16:51
@github-actions github-actions bot added this to the 7.61.0 milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automatic/test-infra-bump changelog/no-changelog medium review PR review might take time qa/no-code-change No code change in Agent code requiring validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants