Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golang.org/x deps #31958

Merged
merged 5 commits into from
Dec 12, 2024
Merged

Update golang.org/x deps #31958

merged 5 commits into from
Dec 12, 2024

Conversation

pgimalac
Copy link
Member

@pgimalac pgimalac commented Dec 10, 2024

What does this PR do?

Update all golang.org/x/... dependencies.

Motivation

Keep dependencies up to date and close a dozen dependabot PRs.

Update go golang.org/x/crypto to 0.31.0 fixes CVE-2024-45337.

Describe how you validated your changes

Handled by CI.

Possible Drawbacks / Trade-offs

Additional Notes

I should make a scheduled github workflow to open this PR as it becomes annoying.

@pgimalac pgimalac added changelog/no-changelog team/agent-shared-components qa/done QA done before merge and regressions are covered by tests labels Dec 10, 2024
@github-actions github-actions bot added component/system-probe long review PR is complex, plan time to review it labels Dec 10, 2024
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 10, 2024

Package size comparison

Comparison with ancestor 22edfebf2aa1cc44aceff9da5b46f2fb185a5a53

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.02MB ⚠️ 1266.01MB 1265.99MB 140.00MB
datadog-iot-agent-amd64-deb 0.01MB ⚠️ 113.27MB 113.27MB 10.00MB
datadog-dogstatsd-amd64-deb 0.01MB ⚠️ 78.51MB 78.50MB 10.00MB
datadog-heroku-agent-amd64-deb 0.02MB ⚠️ 526.75MB 526.73MB 70.00MB
datadog-agent-x86_64-rpm 0.02MB ⚠️ 1275.25MB 1275.22MB 140.00MB
datadog-agent-x86_64-suse 0.02MB ⚠️ 1275.25MB 1275.22MB 140.00MB
datadog-iot-agent-x86_64-rpm 0.01MB ⚠️ 113.34MB 113.34MB 10.00MB
datadog-iot-agent-x86_64-suse 0.01MB ⚠️ 113.34MB 113.33MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB ⚠️ 78.59MB 78.58MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB ⚠️ 78.59MB 78.58MB 10.00MB
datadog-agent-arm64-deb 0.02MB ⚠️ 1001.01MB 1000.98MB 140.00MB
datadog-iot-agent-arm64-deb 0.01MB ⚠️ 108.76MB 108.75MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB ⚠️ 55.73MB 55.73MB 10.00MB
datadog-agent-aarch64-rpm 0.02MB ⚠️ 1010.22MB 1010.20MB 140.00MB
datadog-iot-agent-aarch64-rpm 0.01MB ⚠️ 108.83MB 108.82MB 10.00MB

Decision

⚠️ Warning

Copy link

cit-pr-commenter bot commented Dec 10, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 395b2109-7325-4059-8ae6-d43369f58cec

Baseline: 22edfeb
Comparison: bfdfcda
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +1.07 [+0.34, +1.80] 1 Logs
file_tree memory utilization +0.75 [+0.63, +0.87] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.32 [+0.25, +0.39] 1 Logs
otel_to_otel_logs ingress throughput +0.29 [-0.37, +0.95] 1 Logs
quality_gate_idle_all_features memory utilization +0.20 [+0.08, +0.33] 1 Logs bounds checks dashboard
file_to_blackhole_300ms_latency egress throughput +0.16 [-0.47, +0.79] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.16 [-0.72, +1.04] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.02 [-0.87, +0.92] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.02 [-0.66, +0.70] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.00 [-0.79, +0.79] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.12, +0.09] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.09 [-0.54, +0.36] 1 Logs
quality_gate_logs % cpu utilization -0.19 [-3.12, +2.74] 1 Logs
quality_gate_idle memory utilization -0.20 [-0.24, -0.15] 1 Logs bounds checks dashboard
file_to_blackhole_500ms_latency egress throughput -0.33 [-1.10, +0.44] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.35 [-1.13, +0.43] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency_http2 lost_bytes 9/10
file_to_blackhole_100ms_latency lost_bytes 9/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@pgimalac pgimalac marked this pull request as ready for review December 10, 2024 18:04
@pgimalac pgimalac requested review from a team as code owners December 10, 2024 18:04
Copy link
Member

@davidor davidor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for container-platform files

@pgimalac
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 12, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-12 15:55:31 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 26m.


2024-12-12 16:34:34 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 5b2054c into main Dec 12, 2024
410 checks passed
@dd-mergequeue dd-mergequeue bot deleted the pgimalac/update-golang-org-x-2 branch December 12, 2024 16:34
@github-actions github-actions bot added this to the 7.62.0 milestone Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests team/agent-shared-components
Projects
None yet
Development

Successfully merging this pull request may close these issues.