[netpath] Add windows e2e tests for network path integration #32006

AlexandreYang · 2024-12-11T11:07:45Z

What does this PR do?

[netpath] Add windows e2e tests for network path integration

Motivation

better coverage

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

agent-platform-auto-pr · 2024-12-11T11:31:00Z

[Fast Unit Tests Report]

On pipeline 50924212 (CI Visibility). The following jobs did not run any unit tests:

Jobs:

tests_deb-arm64-py3
tests_deb-x64-py3
tests_flavor_dogstatsd_deb-x64
tests_flavor_heroku_deb-x64
tests_flavor_iot_deb-x64
tests_rpm-arm64-py3
tests_rpm-x64-py3
tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

cit-pr-commenter · 2024-12-11T12:09:47Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 76e0319d-5507-40c3-ae0a-60a27a6c4161

Baseline: 367c4b6
Comparison: b462f8e
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_idle	memory utilization	+1.05	[+1.01, +1.10]	1	Logs bounds checks dashboard
➖	otel_to_otel_logs	ingress throughput	+0.73	[+0.09, +1.37]	1	Logs
➖	quality_gate_logs	% cpu utilization	+0.59	[-2.38, +3.55]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	+0.58	[+0.52, +0.65]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.22	[-0.55, +1.00]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	+0.05	[-0.42, +0.52]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	+0.03	[-0.81, +0.88]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.03	[-0.10, +0.15]	1	Logs bounds checks dashboard
➖	file_to_blackhole_0ms_latency_http1	egress throughput	+0.03	[-0.87, +0.92]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.02	[-0.08, +0.13]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.01	[-0.71, +0.73]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.01]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.01	[-0.79, +0.77]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	-0.12	[-0.75, +0.51]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.20	[-0.99, +0.59]	1	Logs
➖	file_tree	memory utilization	-0.61	[-0.73, -0.48]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-0.67	[-1.40, +0.05]	1	Logs

Bounds Checks: ❌ Failed

perf	experiment	bounds_check_name	replicates_passed	links
❌	file_to_blackhole_500ms_latency	lost_bytes	8/10
❌	file_to_blackhole_0ms_latency_http2	lost_bytes	9/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

agent-platform-auto-pr · 2024-12-11T13:54:53Z

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=50924212 --os-family=ubuntu

Note: This applies to commit b462f8e

agent-platform-auto-pr · 2024-12-11T13:54:56Z

Package size comparison

Comparison with ancestor 367c4b6154a709751eac1c92b7d0b0957aa83511

Diff per package

package	diff	status	size	ancestor	threshold
datadog-agent-amd64-deb	0.00MB	✅	1265.83MB	1265.83MB	140.00MB
datadog-iot-agent-amd64-deb	0.00MB	✅	113.26MB	113.26MB	10.00MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	78.41MB	78.41MB	10.00MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	526.60MB	526.60MB	70.00MB
datadog-agent-x86_64-rpm	0.00MB	⚠️	1275.07MB	1275.06MB	140.00MB
datadog-agent-x86_64-suse	0.00MB	⚠️	1275.07MB	1275.06MB	140.00MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	113.33MB	113.33MB	10.00MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	113.33MB	113.33MB	10.00MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	78.49MB	78.49MB	10.00MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	78.49MB	78.49MB	10.00MB
datadog-agent-arm64-deb	0.02MB	⚠️	1000.85MB	1000.83MB	140.00MB
datadog-iot-agent-arm64-deb	0.00MB	✅	108.75MB	108.75MB	10.00MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	55.64MB	55.64MB	10.00MB
datadog-agent-aarch64-rpm	0.02MB	⚠️	1010.06MB	1010.04MB	140.00MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	108.82MB	108.82MB	10.00MB

Decision

⚠️ Warning

agent-platform-auto-pr · 2024-12-11T18:40:24Z

Gitlab CI Configuration Changes

Modified Jobs

new-e2e-netpath

  new-e2e-netpath:
    after_script:
    - $CI_PROJECT_DIR/tools/ci/junit_upload.sh
    artifacts:
      expire_in: 2 weeks
      paths:
      - $E2E_OUTPUT_DIR
      - junit-*.tgz
      reports:
        annotations:
        - $EXTERNAL_LINKS_PATH
      when: always
    before_script:
    - mkdir -p $GOPATH/pkg/mod/cache && tar xJf modcache_e2e.tar.xz -C $GOPATH/pkg/mod/cache
    - rm -f modcache_e2e.tar.xz
    - mkdir -p ~/.aws
    - $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_QA_E2E profile >> ~/.aws/config
      || exit $?
    - export AWS_PROFILE=agent-qa-ci
    - $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_QA_E2E ssh_public_key_rsa > $E2E_AWS_PUBLIC_KEY_PATH
      || exit $?
    - touch $E2E_AWS_PRIVATE_KEY_PATH && chmod 600 $E2E_AWS_PRIVATE_KEY_PATH && $CI_PROJECT_DIR/tools/ci/fetch_secret.sh
      $AGENT_QA_E2E ssh_key_rsa > $E2E_AWS_PRIVATE_KEY_PATH || exit $?
    - $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_QA_E2E ssh_public_key_rsa > $E2E_AZURE_PUBLIC_KEY_PATH
      || exit $?
    - touch $E2E_AZURE_PRIVATE_KEY_PATH && chmod 600 $E2E_AZURE_PRIVATE_KEY_PATH &&
      $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_QA_E2E ssh_key_rsa > $E2E_AZURE_PRIVATE_KEY_PATH
      || exit $?
    - $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_QA_E2E ssh_public_key_rsa > $E2E_GCP_PUBLIC_KEY_PATH
      || exit $?
    - touch $E2E_GCP_PRIVATE_KEY_PATH && chmod 600 $E2E_GCP_PRIVATE_KEY_PATH && $CI_PROJECT_DIR/tools/ci/fetch_secret.sh
      $AGENT_QA_E2E ssh_key_rsa > $E2E_GCP_PRIVATE_KEY_PATH || exit $?
    - pulumi login "s3://dd-pulumi-state?region=us-east-1&awssdk=v2&profile=$AWS_PROFILE"
    - ARM_CLIENT_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $E2E_AZURE client_id)
      || exit $?; export ARM_CLIENT_ID
    - ARM_CLIENT_SECRET=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $E2E_AZURE token)
      || exit $?; export ARM_CLIENT_SECRET
    - ARM_TENANT_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $E2E_AZURE tenant_id)
      || exit $?; export ARM_TENANT_ID
    - ARM_SUBSCRIPTION_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $E2E_AZURE subscription_id)
      || exit $?; export ARM_SUBSCRIPTION_ID
    - $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $E2E_GCP credentials_json > ~/gcp-credentials.json
      || exit $?
    - export GOOGLE_APPLICATION_CREDENTIALS=~/gcp-credentials.json
    - inv -e gitlab.generate-ci-visibility-links --output=$EXTERNAL_LINKS_PATH
    image: registry.ddbuild.io/ci/test-infra-definitions/runner$TEST_INFRA_DEFINITIONS_BUILDIMAGES_SUFFIX:$TEST_INFRA_DEFINITIONS_BUILDIMAGES
    needs:
    - go_e2e_deps
    - deploy_deb_testing-a7_x64
+   - deploy_windows_testing-a7
    rules:
    - if: $RUN_E2E_TESTS == "off"
      when: never
    - if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
      when: never
    - if: $RUN_E2E_TESTS == "on"
      when: on_success
    - if: $CI_COMMIT_BRANCH == "main"
      when: on_success
    - if: $CI_COMMIT_BRANCH =~ /^[0-9]+\.[0-9]+\.x$/
      when: on_success
    - if: $CI_COMMIT_TAG =~ /^[0-9]+\.[0-9]+\.[0-9]+-rc\.[0-9]+$/
      when: on_success
    - changes:
        compare_to: main
        paths:
        - .gitlab/e2e/e2e.yml
        - test/new-e2e/pkg/**/*
        - test/new-e2e/go.mod
        - flakes.yaml
    - changes:
        compare_to: main
        paths:
        - pkg/collector/corechecks/networkpath/**/*
        - test/new-e2e/tests/netpath/**/*
        - test/new-e2e/go.mod
      when: on_success
    - if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
      when: never
    - allow_failure: true
      when: manual
    script:
    - inv -e new-e2e-tests.run --targets $TARGETS -c ddagent:imagePullRegistry=669783387624.dkr.ecr.us-east-1.amazonaws.com
      -c ddagent:imagePullUsername=AWS -c ddagent:imagePullPassword=$(aws ecr get-login-password)
      --junit-tar junit-${CI_JOB_ID}.tgz ${EXTRA_PARAMS} --test-washer --logs-folder=$E2E_OUTPUT_DIR/logs
      --logs-post-processing --logs-post-processing-test-depth=$E2E_LOGS_PROCESSING_TEST_DEPTH
    stage: e2e
    tags:
    - arch:amd64
    variables:
      E2E_AWS_PRIVATE_KEY_PATH: /tmp/agent-qa-aws-ssh-key
      E2E_AWS_PUBLIC_KEY_PATH: /tmp/agent-qa-aws-ssh-key.pub
      E2E_AZURE_PRIVATE_KEY_PATH: /tmp/agent-qa-azure-ssh-key
      E2E_AZURE_PUBLIC_KEY_PATH: /tmp/agent-qa-azure-ssh-key.pub
      E2E_COMMIT_SHA: $CI_COMMIT_SHORT_SHA
      E2E_GCP_PRIVATE_KEY_PATH: /tmp/agent-qa-gcp-ssh-key
      E2E_GCP_PUBLIC_KEY_PATH: /tmp/agent-qa-gcp-ssh-key.pub
      E2E_KEY_PAIR_NAME: datadog-agent-ci-rsa
      E2E_LOGS_PROCESSING_TEST_DEPTH: 1
      E2E_OUTPUT_DIR: $CI_PROJECT_DIR/e2e-output
      E2E_PIPELINE_ID: $CI_PIPELINE_ID
      EXTERNAL_LINKS_PATH: external_links_$CI_JOB_ID.json
      KUBERNETES_CPU_REQUEST: 6
      KUBERNETES_MEMORY_LIMIT: 16Gi
      KUBERNETES_MEMORY_REQUEST: 12Gi
      SHOULD_RUN_IN_FLAKES_FINDER: 'true'
      TARGETS: ./tests/netpath
      TEAM: network-performance-monitoring

Changes Summary

Removed	Modified	Added	Renamed
0	1	0	0

ℹ️ Diff available in the job log.

AlexandreYang · 2024-12-12T16:09:05Z

/merge

dd-devflow · 2024-12-12T16:09:20Z

Devflow running: `/merge`

View all feedbacks in Devflow UI.

2024-12-12 16:09:20 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 26m.

2024-12-12 16:12:09 UTC 🚨 MergeQueue: This merge request is in error

Gitlab pipeline didn't start on its own and we were unable to create it... Please retry.

AlexandreYang · 2024-12-12T16:18:34Z

/merge

dd-devflow · 2024-12-12T16:18:58Z

Devflow running: `/merge`

View all feedbacks in Devflow UI.

2024-12-12 16:18:58 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 26m.

2024-12-12 16:53:36 UTC ℹ️ MergeQueue: This merge request was merged

AlexandreYang added 2 commits December 11, 2024 12:07

[netpath] Refactor e2e tests

ffc6afe

rename

28a34e0

github-actions bot added short review PR is simple enough to be reviewed quickly team/networks team/network-device-monitoring labels Dec 11, 2024

AlexandreYang added 2 commits December 11, 2024 12:08

rename

8583569

add

9153acb

github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Dec 11, 2024

AlexandreYang added 5 commits December 11, 2024 14:16

fix package name

cc980c3

fix package name

34b4717

fix unused

25abb7e

parallel

c3fccc0

fix test

e9d267c

AlexandreYang added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Dec 11, 2024

AlexandreYang changed the title ~~[netpath] Refactor e2e tests~~ [netpath] Add windows e2e tests Dec 11, 2024

AlexandreYang changed the title ~~[netpath] Add windows e2e tests~~ [netpath] Add windows e2e tests for network path integration Dec 11, 2024

update tests

822a1ef

AlexandreYang added 7 commits December 11, 2024 14:59

refactor

918d1d8

fix name

d7925eb

Merge branch 'main' into alex/netpath-e2e-windows

3bcff72

updat tests

186413b

fix test

5df7710

rename

77da96f

log

114ee23

AlexandreYang added 2 commits December 11, 2024 19:36

need windows

fea5123

fix name

427ef33

AlexandreYang marked this pull request as ready for review December 11, 2024 18:38

AlexandreYang requested review from a team as code owners December 11, 2024 18:38

AlexandreYang requested a review from mbakht December 11, 2024 18:38

AlexandreYang added 3 commits December 11, 2024 22:06

Merge branch 'main' into alex/netpath-e2e-windows

23e35a2

refactor

43769e8

remove t

b462f8e

vboulineau approved these changes Dec 12, 2024

View reviewed changes

L3n41c approved these changes Dec 12, 2024

View reviewed changes

hmahmood approved these changes Dec 12, 2024

View reviewed changes

dd-mergequeue bot merged commit 004f117 into main Dec 12, 2024
313 checks passed

dd-mergequeue bot deleted the alex/netpath-e2e-windows branch December 12, 2024 16:53

github-actions bot added this to the 7.62.0 milestone Dec 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[netpath] Add windows e2e tests for network path integration #32006

[netpath] Add windows e2e tests for network path integration #32006

AlexandreYang commented Dec 11, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 11, 2024 •

edited

Loading

cit-pr-commenter bot commented Dec 11, 2024 •

edited

Loading

Fine details of change detection per experiment

Explanation

agent-platform-auto-pr bot commented Dec 11, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 11, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 11, 2024 •

edited

Loading

AlexandreYang commented Dec 12, 2024

dd-devflow bot commented Dec 12, 2024 •

edited

Loading

AlexandreYang commented Dec 12, 2024

dd-devflow bot commented Dec 12, 2024 •

edited

Loading

[netpath] Add windows e2e tests for network path integration #32006

[netpath] Add windows e2e tests for network path integration #32006

Conversation

AlexandreYang commented Dec 11, 2024 • edited Loading

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

agent-platform-auto-pr bot commented Dec 11, 2024 • edited Loading

cit-pr-commenter bot commented Dec 11, 2024 • edited Loading

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

Bounds Checks: ❌ Failed

Explanation

CI Pass/Fail Decision

agent-platform-auto-pr bot commented Dec 11, 2024 • edited Loading

Test changes on VM

agent-platform-auto-pr bot commented Dec 11, 2024 • edited Loading

Package size comparison

Decision

agent-platform-auto-pr bot commented Dec 11, 2024 • edited Loading

Gitlab CI Configuration Changes

Modified Jobs

Changes Summary

AlexandreYang commented Dec 12, 2024

dd-devflow bot commented Dec 12, 2024 • edited Loading

Devflow running: /merge

AlexandreYang commented Dec 12, 2024

dd-devflow bot commented Dec 12, 2024 • edited Loading

Devflow running: /merge

AlexandreYang commented Dec 11, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 11, 2024 •

edited

Loading

cit-pr-commenter bot commented Dec 11, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 11, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 11, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 11, 2024 •

edited

Loading

dd-devflow bot commented Dec 12, 2024 •

edited

Loading

Devflow running: `/merge`

dd-devflow bot commented Dec 12, 2024 •

edited

Loading

Devflow running: `/merge`