Revert "Revert "When running in CI, scrub e2e tests output to avoid leaking keys"" #32044

KevinFairise2 · 2024-12-11T16:38:33Z

Reverts #32027

Tried to make an e2e test fail: https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/735205063

…eaking k…" This reverts commit 8a5e662.

agent-platform-auto-pr · 2024-12-11T17:16:44Z

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=50858230 --os-family=ubuntu

Note: This applies to commit 28db953

agent-platform-auto-pr · 2024-12-11T17:18:31Z

Package size comparison

Comparison with ancestor 56658fee3937e50cae033381d308c96880b91faa

Diff per package

package	diff	status	size	ancestor	threshold
datadog-agent-amd64-deb	-0.02MB	✅	1271.60MB	1271.61MB	140.00MB
datadog-iot-agent-amd64-deb	0.00MB	✅	113.29MB	113.29MB	10.00MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	78.41MB	78.41MB	10.00MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	526.65MB	526.65MB	70.00MB
datadog-agent-x86_64-rpm	-0.02MB	✅	1280.83MB	1280.85MB	140.00MB
datadog-agent-x86_64-suse	-0.02MB	✅	1280.83MB	1280.85MB	140.00MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	113.35MB	113.35MB	10.00MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	113.35MB	113.35MB	10.00MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	78.49MB	78.49MB	10.00MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	78.49MB	78.49MB	10.00MB
datadog-agent-arm64-deb	0.01MB	⚠️	1005.68MB	1005.67MB	140.00MB
datadog-iot-agent-arm64-deb	0.00MB	✅	108.76MB	108.76MB	10.00MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	55.64MB	55.64MB	10.00MB
datadog-agent-aarch64-rpm	0.01MB	⚠️	1014.90MB	1014.89MB	140.00MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	108.83MB	108.83MB	10.00MB

Decision

⚠️ Warning

agent-platform-auto-pr · 2024-12-11T17:28:39Z

[Fast Unit Tests Report]

On pipeline 50927679 (CI Visibility). The following jobs did not run any unit tests:

Jobs:

tests_deb-arm64-py3
tests_deb-x64-py3
tests_flavor_dogstatsd_deb-x64
tests_flavor_heroku_deb-x64
tests_flavor_iot_deb-x64
tests_rpm-arm64-py3
tests_rpm-x64-py3
tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

cit-pr-commenter · 2024-12-12T10:02:43Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: c81ce8d6-5517-4173-8711-c4cfaf6860c9

Baseline: 56658fe
Comparison: ac3ae12
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	file_tree	memory utilization	+1.06	[+0.94, +1.17]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.73	[+0.59, +0.86]	1	Logs bounds checks dashboard
➖	quality_gate_logs	% cpu utilization	+0.59	[-2.35, +3.52]	1	Logs
➖	quality_gate_idle	memory utilization	+0.42	[+0.38, +0.47]	1	Logs bounds checks dashboard
➖	file_to_blackhole_500ms_latency	egress throughput	+0.19	[-0.57, +0.95]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.10	[-0.67, +0.87]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.04	[-0.67, +0.75]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.01	[-0.84, +0.86]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.01	[-0.09, +0.10]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	+0.00	[-0.83, +0.84]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.01]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	-0.08	[-0.96, +0.80]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	-0.21	[-0.84, +0.43]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	-0.22	[-0.69, +0.24]	1	Logs
➖	otel_to_otel_logs	ingress throughput	-0.55	[-1.21, +0.12]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-1.26	[-1.98, -0.54]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-1.83	[-1.89, -1.76]	1	Logs

Bounds Checks: ❌ Failed

perf	experiment	bounds_check_name	replicates_passed	links
❌	file_to_blackhole_500ms_latency	lost_bytes	6/10
❌	file_to_blackhole_0ms_latency_http2	lost_bytes	7/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

pducolin · 2024-12-12T10:56:25Z

tasks/tools/gotest-scrubbed.sh

+#!/bin/bash
+### This script is used to run go test and scrub the output, the command can be used as follow:
+### ./gotest-scrubbed.sh <packages comma separated> -- <go tests flags>
+set -euo pipefail


💬 suggestion

Suggested change

set -euo pipefail

# bash strict mode, fail if go test fails

set -euo pipefail

❓ question
Does it apply the pipe if go test fails?

Yeah that's a valid point. But I tested and it does.
According to bash doc it always apply all the pipes, it only change the returned error value.

If set, the return value of a pipeline is the value of the last (rightmost) command to exit with a non-zero status, or zero if all commands in the pipeline exit successfully

KevinFairise2 · 2024-12-12T12:18:42Z

/merge

dd-devflow · 2024-12-12T12:18:54Z

Devflow running: `/merge`

View all feedbacks in Devflow UI.

2024-12-12 12:18:54 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2024-12-12 12:20:57 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 27m.

2024-12-12 12:45:05 UTC ℹ️ MergeQueue: This merge request was merged

Revert "Revert "When running in CI, scrub e2e tests output to avoid l…

3a81173

…eaking k…" This reverts commit 8a5e662.

KevinFairise2 requested review from a team as code owners December 11, 2024 16:38

github-actions bot added team/agent-devx-loops short review PR is simple enough to be reviewed quickly labels Dec 11, 2024

Make sure go test fail if a test fail

ac3ae12

KevinFairise2 force-pushed the revert-32027-revert-31902-kfairise/go-test-scrubbing branch from 28db953 to ac3ae12 Compare December 12, 2024 09:14

chouetz approved these changes Dec 12, 2024

View reviewed changes

KevinFairise2 added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Dec 12, 2024

pducolin approved these changes Dec 12, 2024

View reviewed changes

github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Dec 12, 2024

amenasria approved these changes Dec 12, 2024

View reviewed changes

dd-mergequeue bot merged commit 9419cbb into main Dec 12, 2024
246 of 250 checks passed

dd-mergequeue bot deleted the revert-32027-revert-31902-kfairise/go-test-scrubbing branch December 12, 2024 12:45

github-actions bot added this to the 7.62.0 milestone Dec 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revert "Revert "When running in CI, scrub e2e tests output to avoid leaking keys"" #32044

Revert "Revert "When running in CI, scrub e2e tests output to avoid leaking keys"" #32044

KevinFairise2 commented Dec 11, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 11, 2024

agent-platform-auto-pr bot commented Dec 11, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 11, 2024 •

edited

Loading

cit-pr-commenter bot commented Dec 12, 2024

Fine details of change detection per experiment

Explanation

pducolin Dec 12, 2024

pducolin Dec 12, 2024

KevinFairise2 Dec 12, 2024

KevinFairise2 commented Dec 12, 2024

dd-devflow bot commented Dec 12, 2024 •

edited

Loading

	set -euo pipefail
	# bash strict mode, fail if go test fails
	set -euo pipefail

Revert "Revert "When running in CI, scrub e2e tests output to avoid leaking keys"" #32044

Revert "Revert "When running in CI, scrub e2e tests output to avoid leaking keys"" #32044

Conversation

KevinFairise2 commented Dec 11, 2024 • edited Loading

agent-platform-auto-pr bot commented Dec 11, 2024

Test changes on VM

agent-platform-auto-pr bot commented Dec 11, 2024 • edited Loading

Package size comparison

Decision

agent-platform-auto-pr bot commented Dec 11, 2024 • edited Loading

cit-pr-commenter bot commented Dec 12, 2024

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

Bounds Checks: ❌ Failed

Explanation

CI Pass/Fail Decision

pducolin Dec 12, 2024

Choose a reason for hiding this comment

pducolin Dec 12, 2024

Choose a reason for hiding this comment

KevinFairise2 Dec 12, 2024

Choose a reason for hiding this comment

KevinFairise2 commented Dec 12, 2024

dd-devflow bot commented Dec 12, 2024 • edited Loading

Devflow running: /merge

KevinFairise2 commented Dec 11, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 11, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 11, 2024 •

edited

Loading

dd-devflow bot commented Dec 12, 2024 •

edited

Loading

Devflow running: `/merge`