(fleet) installer setup scripts improvements #32062

arbll · 2024-12-11T20:04:06Z

What does this PR do?

Self-installation of the installer downloaded by the downloader in the setup
Adds proper support for datadog.yaml: nested values, merging with existing configuration, testing
Simplifies the databricks script by merging the logs portion into the spark.d/databricks.yaml integration
Bunch of other small improvements

Describe how you validated your changes

Covered by DJM's e2e

…etup

agent-platform-auto-pr · 2024-12-11T21:08:33Z

Package size comparison

Comparison with ancestor 408926fdc126e1ade9040d16f7ab216ea98fd84e

Diff per package

package	diff	status	size	ancestor	threshold
datadog-agent-amd64-deb	0.00MB	✅	1265.99MB	1265.99MB	140.00MB
datadog-iot-agent-amd64-deb	0.00MB	✅	113.27MB	113.27MB	10.00MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	78.50MB	78.50MB	10.00MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	526.73MB	526.73MB	70.00MB
datadog-agent-x86_64-rpm	0.00MB	✅	1275.22MB	1275.22MB	140.00MB
datadog-agent-x86_64-suse	0.00MB	✅	1275.22MB	1275.22MB	140.00MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	113.34MB	113.34MB	10.00MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	113.33MB	113.33MB	10.00MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	78.58MB	78.58MB	10.00MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	78.58MB	78.58MB	10.00MB
datadog-agent-arm64-deb	0.00MB	✅	1000.98MB	1000.98MB	140.00MB
datadog-iot-agent-arm64-deb	0.00MB	✅	108.75MB	108.75MB	10.00MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	55.73MB	55.73MB	10.00MB
datadog-agent-aarch64-rpm	0.00MB	✅	1010.20MB	1010.20MB	140.00MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	108.82MB	108.82MB	10.00MB

Decision

✅ Passed

agent-platform-auto-pr · 2024-12-11T21:09:19Z

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=50948849 --os-family=ubuntu

Note: This applies to commit cbefe60

cit-pr-commenter · 2024-12-11T21:40:04Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: e3fc854a-ffbb-418d-a317-738d0f3e9650

Baseline: 408926f
Comparison: cbefe60
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+1.51	[-1.45, +4.47]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	+1.40	[+1.33, +1.47]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.35	[-0.38, +1.08]	1	Logs
➖	file_tree	memory utilization	+0.31	[+0.19, +0.44]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.28	[-0.49, +1.05]	1	Logs
➖	quality_gate_idle	memory utilization	+0.25	[+0.21, +0.30]	1	Logs bounds checks dashboard
➖	file_to_blackhole_100ms_latency	egress throughput	+0.14	[-0.64, +0.92]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	+0.06	[-0.58, +0.69]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.01	[-0.09, +0.10]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.01]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.01	[-0.92, +0.89]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	-0.03	[-0.87, +0.80]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	-0.08	[-0.91, +0.76]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.18	[-0.95, +0.59]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	-0.25	[-0.38, -0.13]	1	Logs bounds checks dashboard
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	-0.29	[-0.75, +0.17]	1	Logs
➖	otel_to_otel_logs	ingress throughput	-0.64	[-1.32, +0.05]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

raphaelgavache

nice, couldn't find on first read what breaks the test
will review again tomorrow morning

pkg/fleet/installer/setup/common/config.go

pkg/fleet/installer/setup/common/config_test.go

…etup

arbll · 2024-12-12T13:49:25Z

/merge

dd-devflow · 2024-12-12T13:49:38Z

Devflow running: `/merge`

View all feedbacks in Devflow UI.

2024-12-12 13:49:38 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2024-12-12 14:42:02 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 27m.

2024-12-12 15:08:30 UTC ℹ️ MergeQueue: This merge request was merged

arbll and others added 8 commits December 9, 2024 14:37

rename

0da02c2

Merge remote-tracking branch 'origin/main' into arbll/managed-agent-s…

321496b

…etup

setup declarative refactor, apply the changes to databricks

d2e47b9

wip

2ceec50

version that should work (theoretically)

50a6ff0

add config tests

7eb8c17

Merge remote-tracking branch 'origin/main' into arbll/managed-agent-s…

6f60a5b

…etup

package work

8b2ac08

arbll added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests team/fleet-automation labels Dec 11, 2024

arbll requested review from a team as code owners December 11, 2024 20:04

github-actions bot added the long review PR is complex, plan time to review it label Dec 11, 2024

arbll added 4 commits December 11, 2024 21:08

fix build

829f8fa

self-bootstrap

ceb4660

lint

71c5a90

fix installer URL

651a48a

raphaelgavache reviewed Dec 12, 2024

View reviewed changes

pkg/fleet/installer/setup/common/config.go Show resolved Hide resolved

pkg/fleet/installer/setup/common/config_test.go Show resolved Hide resolved

arbll added 3 commits December 12, 2024 11:28

add logs_enabled, fix tests

8f7f443

Merge remote-tracking branch 'origin/main' into arbll/managed-agent-s…

df18fc6

…etup

fix self-bootstrap

83a9e9e

raphaelgavache approved these changes Dec 12, 2024

View reviewed changes

arbll added 3 commits December 12, 2024 13:55

maybe windows fix

cff8f88

fix port conflict

3773b7b

skip win

cbefe60

dd-mergequeue bot merged commit 68f07c6 into main Dec 12, 2024
241 of 246 checks passed

dd-mergequeue bot deleted the arbll/managed-agent-setup branch December 12, 2024 15:08

github-actions bot added this to the 7.62.0 milestone Dec 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(fleet) installer setup scripts improvements #32062

(fleet) installer setup scripts improvements #32062

arbll commented Dec 11, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 11, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 11, 2024 •

edited

Loading

cit-pr-commenter bot commented Dec 11, 2024 •

edited

Loading

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

raphaelgavache left a comment

arbll commented Dec 12, 2024

dd-devflow bot commented Dec 12, 2024 •

edited

Loading

(fleet) installer setup scripts improvements #32062

(fleet) installer setup scripts improvements #32062

Conversation

arbll commented Dec 11, 2024 • edited Loading

What does this PR do?

Describe how you validated your changes

agent-platform-auto-pr bot commented Dec 11, 2024 • edited Loading

Package size comparison

Decision

agent-platform-auto-pr bot commented Dec 11, 2024 • edited Loading

Test changes on VM

cit-pr-commenter bot commented Dec 11, 2024 • edited Loading

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

raphaelgavache left a comment

Choose a reason for hiding this comment

arbll commented Dec 12, 2024

dd-devflow bot commented Dec 12, 2024 • edited Loading

Devflow running: /merge

arbll commented Dec 11, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 11, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 11, 2024 •

edited

Loading

cit-pr-commenter bot commented Dec 11, 2024 •

edited

Loading

dd-devflow bot commented Dec 12, 2024 •

edited

Loading

Devflow running: `/merge`