fix[datadog-installer]: Handle 'file not found' error in removeUnit function #32066
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unction 🤖 This pull request was automatically generated by Datadog Error Tracking Assistant, requested by [email protected]. Applies Datadog Error Tracking Assistant suggestions for issue: [ddb74c5c-ae6d-11ef-b346-da7ad0900002](https://app.datadoghq.com/error-tracking?issueId=ddb74c5c-ae6d-11ef-b346-da7ad0900002). --- This pull request fixes an issue where attempting to remove a non-existent systemd unit file causes an error that propagates and leads to an exception in the tracer. **Problem:** The `removeUnit` function attempts to remove systemd unit files using `os.Remove`. If the unit file does not exist, `os.Remove` returns an error stating "no such file or directory". This error is then passed to the DataDog tracer via `tracer.WithError(err)` in the deferred function, which can cause an unexpected exception within the tracer code. **Solution:** The code has been modified to check if the error returned by `os.Remove` is due to the file not existing. By using `os.IsNotExist(err)`, we determine if the error is benign (the file is already absent). If so, we set `err` to `nil`, effectively ignoring the error. This prevents unnecessary errors from being passed to the tracer and avoids exceptions when the unit file is already removed. **Summary of Changes:** - Updated the `removeUnit` function to handle "file not found" errors gracefully. - Added a check for `os.IsNotExist(err)` after the call to `os.Remove`. - If the unit file does not exist, the error is suppressed by setting `err` to `nil`. **Impact:** This change ensures that the removal process is idempotent and does not raise unnecessary exceptions when systemd unit files are already absent. It improves the stability of the uninstall process and prevents misleading error logs related to non-critical file absence.
|
|
github-actions
bot
added
team/windows-agent
short review
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv aws.create-vm --pipeline-id=50931281 --os-family=ubuntuNote: This applies to commit fe725df |
Package size comparisonComparison with ancestor Diff per package
Decision |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 367c4b6 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.84 | [+0.77, +0.90] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | +0.59 | [-2.36, +3.55] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.28 | [+0.15, +0.41] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.21 | [-0.56, +0.99] | 1 | Logs |
| ➖ | otel_to_otel_logs | ingress throughput | +0.10 | [-0.59, +0.79] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | +0.01 | [-0.81, +0.84] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.10, +0.10] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.02 | [-0.81, +0.76] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | -0.04 | [-0.84, +0.77] | 1 | Logs |
| ➖ | file_to_blackhole_300ms_latency | egress throughput | -0.04 | [-0.67, +0.59] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | -0.05 | [-0.51, +0.41] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.06 | [-0.76, +0.65] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.09 | [-0.86, +0.68] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -0.11 | [-0.15, -0.06] | 1 | Logs bounds checks dashboard |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.31 | [-1.03, +0.42] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.47 | [-0.59, -0.35] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | |
| ✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
arbll
approved these changes
Dec 12, 2024
arbll
added
qa/done
|
/merge |
Devflow running:
|
|
/merge |
Devflow running:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 This pull request was automatically generated by Datadog Error Tracking Assistant, requested by [email protected].
Applies Datadog Error Tracking Assistant suggestions for issue: ddb74c5c-ae6d-11ef-b346-da7ad0900002.
This pull request fixes an issue where attempting to remove a non-existent systemd unit file causes an error that propagates and leads to an exception in the tracer.
Problem:
The
removeUnitfunction attempts to remove systemd unit files usingos.Remove. If the unit file does not exist,os.Removereturns an error stating "no such file or directory". This error is then passed to the DataDog tracer viatracer.WithError(err)in the deferred function, which can cause an unexpected exception within the tracer code.Solution:
The code has been modified to check if the error returned by
os.Removeis due to the file not existing. By usingos.IsNotExist(err), we determine if the error is benign (the file is already absent). If so, we seterrtonil, effectively ignoring the error. This prevents unnecessary errors from being passed to the tracer and avoids exceptions when the unit file is already removed.Summary of Changes:
removeUnitfunction to handle "file not found" errors gracefully.os.IsNotExist(err)after the call toos.Remove.errtonil.Impact:
This change ensures that the removal process is idempotent and does not raise unnecessary exceptions when systemd unit files are already absent. It improves the stability of the uninstall process and prevents misleading error logs related to non-critical file absence.