From 040017b25bae49a9e0f53d00e437ce1d428ae710 Mon Sep 17 00:00:00 2001 From: Thomas Hunter II Date: Thu, 16 May 2024 14:10:46 -0700 Subject: [PATCH] mention zero subscribers bug --- checks.js | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/checks.js b/checks.js index 371d6ee..54c14e6 100644 --- a/checks.js +++ b/checks.js @@ -8,8 +8,11 @@ function hasFullSupport() { } module.exports.hasFullSupport = hasFullSupport; +// Node.js v19.9.0 has the "zero subscribers bug" which is pretty nasty. +// for that reason we overwrite the TracingChannel implementation entirely. function hasTracingChannel() { return (MAJOR >= 20) + // || (MAJOR === 19 && MINOR >= 9) || (MAJOR === 18 && MINOR >= 19); } module.exports.hasTracingChannel = hasTracingChannel; @@ -33,11 +36,6 @@ function hasGarbageCollectionBug() { } module.exports.hasGarbageCollectionBug = hasGarbageCollectionBug; -function hasZeroSubscribersBug() { - return MAJOR === 19 && MINOR === 9; -} -module.exports.hasZeroSubscribersBug = hasZeroSubscribersBug; - function hasChannelStoreMethods() { return MAJOR >= 20 || (MAJOR === 19 && MINOR >= 9);