Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: add support for github.com/bradfitz/gomemcache #290

Closed
dd-caleb opened this issue Jul 31, 2018 · 0 comments
Closed

proposal: add support for github.com/bradfitz/gomemcache #290

dd-caleb opened this issue Jul 31, 2018 · 0 comments
Labels
apm:ecosystem contrib/* related feature requests or bugs

Comments

@dd-caleb
Copy link
Contributor

The github.com/bradfitz/gomemcache package seems to be the most popular memcache client. We should add tracing support.

Looking at the library, it doesn't currently support Context, so I submitted an issue: bradfitz/gomemcache#84.

Regardless we can create a new Client that wraps the memcache.Client, implements all the same methods, and also supports a WithContext method:

func (c *Client) WithContext(ctx context.Context) *Client

Then subsequent calls on the new Client would use that context as the parent for spans.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

No branches or pull requests

1 participant