From 1710fe34aab6930d3ea2cc5c5cf68c15b7ef21a5 Mon Sep 17 00:00:00 2001 From: Taegyun Kim Date: Wed, 31 Jul 2024 10:25:29 -0400 Subject: [PATCH] fix(profiling): propagates runtime_id to libdatadog exporter (#9987) ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) --- .../datadog/profiling/dd_wrapper/src/uploader_builder.cpp | 1 + .../notes/profiling-stack-v2-runtime-7a4700f8571deddc.yaml | 6 ++++++ 2 files changed, 7 insertions(+) create mode 100644 releasenotes/notes/profiling-stack-v2-runtime-7a4700f8571deddc.yaml diff --git a/ddtrace/internal/datadog/profiling/dd_wrapper/src/uploader_builder.cpp b/ddtrace/internal/datadog/profiling/dd_wrapper/src/uploader_builder.cpp index 3047688475a..5408d2d6b00 100644 --- a/ddtrace/internal/datadog/profiling/dd_wrapper/src/uploader_builder.cpp +++ b/ddtrace/internal/datadog/profiling/dd_wrapper/src/uploader_builder.cpp @@ -116,6 +116,7 @@ Datadog::UploaderBuilder::build() { ExportTagKey::version, version }, { ExportTagKey::language, language }, { ExportTagKey::runtime, runtime }, + { ExportTagKey::runtime_id, runtime_id }, { ExportTagKey::runtime_version, runtime_version }, { ExportTagKey::profiler_version, profiler_version }, }; diff --git a/releasenotes/notes/profiling-stack-v2-runtime-7a4700f8571deddc.yaml b/releasenotes/notes/profiling-stack-v2-runtime-7a4700f8571deddc.yaml new file mode 100644 index 00000000000..a0cd1b7b54e --- /dev/null +++ b/releasenotes/notes/profiling-stack-v2-runtime-7a4700f8571deddc.yaml @@ -0,0 +1,6 @@ +--- +fixes: + - | + profiling: propagates ``runtime_id`` tag to libdatadog exporter. It is + a unique string identifier for the profiled process. For example, Thread + Timeline visualization uses it to distinguish different processes.