Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[registry] malformed tag parameters silently fail #366

Open
jamiealquiza opened this issue Jun 9, 2021 · 0 comments
Open

[registry] malformed tag parameters silently fail #366

jamiealquiza opened this issue Jun 9, 2021 · 0 comments

Comments

@jamiealquiza
Copy link
Collaborator

jamiealquiza commented Jun 9, 2021

When applying a tag filter via curl (behavior with grpc hasn't been reviewed), incorrectly formed tag parameters will not emit an error. This may result in a user unexpected receiving a full object list that includes resources that do not match the intended tags.

Example, incorrectly formed param ("tags" vs "tag") and response, no errors:

$ curl -s "registry/v1/brokers/list?tags:topicmappr_map=pool1" | jq .
{
  "ids": [
    10000,
    10001,
    10002,
    10003,
    10004,
    10005,
    10006,
    10007,
    10008,
    10009,
    10010,
    10011
  ],
  "brokers": {}
}

Correctly formed, different results:

$ curl -s "registry/v1/brokers/list?tag=topicmappr_map:pool1" | jq .
{
  "ids": [
    10006,
    10007,
    10008,
    10009,
    10010,
    10011
  ],
  "brokers": {}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant