Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Readme says dogstatsd-no-workers = true, but output has worker metrics #21

Open
grayaii opened this issue Dec 5, 2020 · 2 comments

Comments

@grayaii
Copy link

grayaii commented Dec 5, 2020

The example in the README.md says:
...
dogstatsd-no-workers = true
...

This will begin producing metrics with the prefix defined in the configuration, myapp here:
....
myapp.worker.avg_response_time
myapp.worker.core.exceptions
myapp.worker.core.offloaded_requests
myapp.worker.core.read_errors
myapp.worker.core.requests
myapp.worker.core.routed_requests
myapp.worker.core.static_requests
myapp.worker.core.write_errors
myapp.worker.delta_requests
myapp.worker.failed_requests
myapp.worker.requests
myapp.worker.respawns
myapp.worker.rss_size
myapp.worker.total_tx
myapp.worker.vsz_size

But iff dogstatsd-no-workers = true, that means there shouldn't be any worker.*, right?

@grayaii
Copy link
Author

grayaii commented Dec 7, 2020

Dang. I should have ping'ed @nickwilliams-eventbrite in my original post, who made the commit to begin with :)

@stpierre
Copy link

We've hit this too, but I'm not sure it is minor; with large numbers of workers, these metrics have very high cardinality tagging which rapidly balloons custom metric costs. We'd really like to turn them off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants