-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-export ArrowSerialize
, ArrowDeserialize
and ArrowField
at the top
#71
Comments
@aldanor Thanks that makes sense. Can we follow a |
I think prelude makes sense for bigger crates with dozens and dozens of symbols, where in most use cases you would import a lot of at once - it's actually quite a rare scenario. I personally think it's a bad pattern for smaller crates with just a few symbols, and star-imports are best avoided if possible. Clippy even has a Whereas crates where there's just a few 'big' symbols like Serialize/Deserialize in serde typically just re-export them at the top (link) to simplify life for everyone, while keeping all the other types within their modules (e.g. Here's another good example (
Here's another one ( And another one ( In fact, if I might suggest, renaming Apologies for being so pedantic, I just wanted to help make this crate more conformant to the typical layout of crates of this type :) |
No problem, all good suggestions and makes sense to me. Please go for it! |
Sounds good, I'll sketch a PR later :) (generics first though!) |
Let's be ergonomic, and more like serde.
There's only 3 modules, they are all tiny, essentially 1 main symbol in each, and having to always access
arrow2_convert::serialize::ArrowSerialize
is not really cool.Also, having both
ArrowField
symbols (trait and proc-macro) in the same scope would be a more common way of doing things and a bit nicer.Plus proc-macros (and regular macros) will generate a lot less code spam.
Suggestion: export all three main traits at the crate root. If that's ok, I can open a quick PR (and I'll update the proc-macros in the generics branch).
The text was updated successfully, but these errors were encountered: