Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST service documentation #147

Open
stuartlewis opened this issue Oct 6, 2015 · 3 comments
Open

REST service documentation #147

stuartlewis opened this issue Oct 6, 2015 · 3 comments

Comments

@stuartlewis
Copy link
Contributor

We need to provide REST documentation - perhaps via the root webpage of the datavault-broker web application?

@stuartlewis
Copy link
Contributor Author

JSONDOC (http://jsondoc.org/) integrated. Now all controllers and models need annotating.

@tomhigginsuom
Copy link
Contributor

I've noticed that JSONDOC doesn't appear to respect @JsonIgnore annotations - so it can include fields which are not actually part of the REST objects which are sent/received. One way around this might be to split our objects so that they have an "interface" object with the required fields for dealing with API clients and a "data model" object which represents what is stored in the DB.

For example, some relationships, IDs and properties won't be known to the API client when creating an object. What appears to the API client as an opaque ID ("Vault ID" for a deposit) is actually an object reference once it's inside the broker.

@stuartlewis
Copy link
Contributor Author

Hmmm... interesting: Removing the jsondoc annotation from the jsonignore'd fields removes it from the table, but not the json on the right hand side of the page.

I've submitted this to the JSONDOC project - and I'll see if they can do that:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants