Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nobrainer support #657

Open
kp666 opened this issue May 31, 2020 · 4 comments
Open

Nobrainer support #657

kp666 opened this issue May 31, 2020 · 4 comments

Comments

@kp666
Copy link

kp666 commented May 31, 2020

Would it be possible to have a rethinkdb support, and would it be possible to achieve it with the current database cleaner?

@botandrose
Copy link
Contributor

Hi @kp666, thanks for the issue!

The current release of database_cleaner is v1.8.5. This release has the list of supported ORMs hard-coded into it, so, no, it is not possible to use the current release with the nobainer ORM for RethinkDB.

However, we're very close to releasing v2.0.0, which splits all the ORM adapters out into a gem for each ORM, and makes it easy for someone to create a new adapter, just like you are suggesting! In fact, yesterday we released version 2.0.0.beta2 of database_cleaner-core (the gem that you would create the rethink adapter with) so that people can test it and discover issues, so this is a perfect opportunity for a motivated individual such as yourself to create database_cleaner-nobrainer!

Instructions for how to do this can be found in the ADAPTERS.md file in this repo. I'm personally invested in making sure it's easy to create a new adapter, so I'm happy to help if you have questions!

@kp666
Copy link
Author

kp666 commented May 31, 2020

Thanks for the update. Let me see what can be done.

@zedtux
Copy link

zedtux commented Oct 6, 2020

Hello @kp666,

I just made one version here. If you'd like to give it a try, feel free to give me your feedback 😉.

@zedtux
Copy link

zedtux commented Nov 3, 2020

BTW @botandrose, would you like to add my gem to the list of adapters, or would you like to take it in your github group?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants